Fix TSS2 creep issue, no need to send standstill request #2716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Route : f66032c2b5aa18ac 2020-12-08--08-35-47
|
|
Changed set to look in from TSS2_CAR to NO_STOP_TIMER_CAR as it is more appropriate for that fix and related to timer |
|
Will also add that this fix as of now was tested on: Corolla, CorollaH, Rav4H, HighlanderH. |
|
LGTM, tested on our corolla. |
sshane
pushed a commit
to sshane/openpilot
that referenced
this pull request
Dec 31, 2020
* Fix TSS2 creep issue, no need to send standstill request * Forgot to add import * Changed set to look in from TSS2_CAR to NO_STOP_TIMER_CAR # Conflicts: # selfdrive/car/toyota/carcontroller.py
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TSS2 vehicles don't need for standstill request to be sent. If we send it PCM will go from status 8 to status 11 upon full stop(that where issue is from as we remove standstill request as soon as status != 8). Status 11 is a 3 seconds timer after which PCM goes into state 7 - standstill and asks to press resume or accelerator. After PCM is entered state 7 - standstill_req = False will not switch it back to cruise (8).
Was tested on Corolla TSS2 and Corolla Hybrid TSS2
Associated discussions: #2508 , #1270 , #2473