Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: manage stale PRs #29367

Merged
merged 7 commits into from
Nov 19, 2023
Merged

CI: manage stale PRs #29367

merged 7 commits into from
Nov 19, 2023

Conversation

adeebshihadeh
Copy link
Contributor

@adeebshihadeh adeebshihadeh commented Aug 13, 2023

I think we want to whitelist issues with a tag and blacklist PRs with a tag.

@jnewb1
Copy link
Contributor

jnewb1 commented Aug 14, 2023

what do you think of these rules for stale PRs:

  • 30 days inactive + 7 days stale = close pr
  • only delete branches that are on the main repo
  • exclude "needs testing" (for stuff that we just need someone in the community to test for us, like a new car port) and "work in progress" (stuff we expect will take a while and the PR is only open for encouraging others to work on it or that we might get around to eventually)
  • comments or pushes don't reset the timer, which would encourage stuff to get merged faster

@jnewb1 jnewb1 marked this pull request as ready for review August 14, 2023 23:15
debug-only: true
exempt-milestones: true
exempt-pr-labels: "Work In Progress"
only-issue-labels: "bug" # only close issues with "bug" label
exempt-pr-labels: "Work In Progress" # if wip, don't mark as stale
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
exempt-pr-labels: "Work In Progress" # if wip, don't mark as stale
exempt-pr-labels: "active-work-in-progress"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"active work in progress" fine? we don't have hyphens in any other label

@adeebshihadeh
Copy link
Contributor Author

Before merging this, I'd like to look over the affected PRs. @sshane can you roughly start assigning them to people? if not sure about one, you can assign to me

@jnewb1 jnewb1 changed the title CI: manage stale issues + PRs CI: manage stale PRs Aug 15, 2023
@jnewb1
Copy link
Contributor

jnewb1 commented Sep 21, 2023

our stale PR PR is about to go stale 😅

Remaining:

@adeebshihadeh adeebshihadeh merged commit 31ef352 into master Nov 19, 2023
22 checks passed
@adeebshihadeh adeebshihadeh deleted the stale branch November 19, 2023 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants