Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

camerad: c++ sensorInfo #30650

Merged
merged 6 commits into from
Dec 8, 2023
Merged

camerad: c++ sensorInfo #30650

merged 6 commits into from
Dec 8, 2023

Conversation

deanlee
Copy link
Contributor

@deanlee deanlee commented Dec 8, 2023 •
edited
Loading

  1. move remaining sensor parameters to SensorInfo
  2. member functions.

@deanlee deanlee marked this pull request as draft December 8, 2023 20:19
@deanlee deanlee changed the title camerad: move remaining sensor parameters to SensorInfo camerad: c++ sensorInfo Dec 8, 2023
@deanlee deanlee marked this pull request as ready for review December 8, 2023 20:35
@deanlee deanlee force-pushed the camerad_more_sensors_data branch from 411b7bb to 3c7aa6c Compare December 8, 2023 20:52
@deanlee deanlee force-pushed the camerad_more_sensors_data branch from 3c7aa6c to f0bf681 Compare December 8, 2023 21:07
@adeebshihadeh
Copy link
Contributor

camera_qcom2.cc is almost under 1k lines now!

@deanlee
Copy link
Contributor Author

deanlee commented Dec 8, 2023

yeah. It looks a lot more comfortable now. :D

@adeebshihadeh
Copy link
Contributor

This segfaults on device. Can you test the camerad PRs on device?

@deanlee
Copy link
Contributor Author

deanlee commented Dec 8, 2023 •
edited
Loading

looks like a same bug as #30642.
the sensor_init called before SensorInfo initialized cause this issue.

I'm traveling these days and don't have device with me.

@adeebshihadeh adeebshihadeh merged commit fb2f2d9 into commaai:master Dec 8, 2023
22 of 23 checks passed
@deanlee deanlee deleted the camerad_more_sensors_data branch December 8, 2023 22:29
@adeebshihadeh
Copy link
Contributor

Wanna remove the last two CAMERA_ID references? Then, I can begin bringing up a new sensor.

@deanlee
Copy link
Contributor Author

deanlee commented Dec 8, 2023

sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deanlee @adeebshihadeh