Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carstate: Parse distance button from steering wheel #30850

Closed
wants to merge 1 commit into from

Conversation

sunnyhaibin
Copy link
Contributor

@sunnyhaibin sunnyhaibin commented Dec 25, 2023

Description

Parse the physical distance button from the steering wheel for all cars with existing signals defined in the DBCs.

  • Platforms that do not have the button signal defined will be excluded.
  • Platforms that have more than one (1) button to adjust the following distance (Plus, Minus, Distance Main, etc.) will only parse from the decreasing button at the moment. One solution is to have all buttons related to the following distance parsed as gapAdjustCruise for simplicity's sake.

Verification

Tested on sunnypilot on all platforms with openpilot Longitudinal Control support for over 12 months

Test routes with the button pressed and confirmed with the following distance changed on the cars' cluster:

@github-actions github-actions bot added the car vehicle-specific label Dec 25, 2023
@sunnyhaibin sunnyhaibin force-pushed the parse-gac branch 4 times, most recently from f4d5422 to a145159 Compare December 25, 2023 20:57
@adeebshihadeh
Copy link
Contributor

adeebshihadeh commented Dec 27, 2023

  • Platforms that do not have the button signal defined will be excluded.
  • Platforms that have more than one (1) button to adjust the following distance (Plus, Minus, Distance Main, etc.) will only parse from the decreasing button at the moment. One solution is to have all buttons related to the following distance parsed as gapAdjustCruise for simplicity's sake.

This is why I wanted to start with just making this exceptions list before asking anyone to make a good PR. Is this documented somewhere?

That being said, this PR doesn't look as big as I thought it would be :)

csouers added a commit to csouers/openpilot that referenced this pull request Jan 14, 2024
Copy link
Contributor

This PR has had no activity for 30 days. It will be automatically closed in 7 days if there is no activity.

@github-actions github-actions bot added the stale label Jan 27, 2024
Copy link
Contributor

github-actions bot commented Feb 4, 2024

This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
car vehicle-specific stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants