Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honda: 2024 CR-V Hybrid Car Port #31527

Closed
wants to merge 30 commits into from

Conversation

vanillagorillaa
Copy link
Contributor

@vanillagorillaa vanillagorillaa commented Feb 21, 2024

Checklist

  • added entry to CarInfo in selfdrive/car/*/values.py and ran selfdrive/car/docs.py to generate new docs
  • test route added to routes.py
  • route with openpilot: 197afc441c1f8c4f/2024-02-21--11-18-08
  • route with stock system: 197afc441c1f8c4f/2024-02-20--21-46-35
  • car harness used (if comma doesn't sell it, put N/A): Bosch C

TODO: Fix regen paddle issue (commaai/opendbc#1100)

Copy link
Contributor

It looks like you didn't use one of the Pull Request templates. Please check the contributing docs. Also make sure that you didn't modify any of the checkboxes or headings within the template.

selfdrive/car/honda/fingerprints.py Outdated Show resolved Hide resolved
selfdrive/car/honda/carstate.py Outdated Show resolved Hide resolved
@github-actions github-actions bot added the car vehicle-specific label Feb 26, 2024
Copy link
Contributor

github-actions bot commented Feb 29, 2024

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • the change is something we merge
    • include a route or your device' dongle ID if relevant

@solaris7
Copy link

I own a 2024 CRV hybrid and I am a software engineer. I'd be happy to install this and troubleshoot this. What are some outstanding things that need to be done to make this work?

@vanillagorillaa
Copy link
Contributor Author

I own a 2024 CRV hybrid and I am a software engineer. I'd be happy to install this and troubleshoot this. What are some outstanding things that need to be done to make this work?

TODO: Fix regen paddle issue (commaai/opendbc#1100)

Been waiting to finish this car (and the Pilot) once the Bosch C harness is for sale on the shop and we can get someone with the new accord set up (these three cars are Honda's new CANFD platform).

@vanillagorillaa vanillagorillaa mentioned this pull request Jun 21, 2024
5 tasks
@sshane
Copy link
Contributor

sshane commented Aug 20, 2024

We've moved the car interfacing code to our opendbc repository, which is now the new home for car ports and fingerprints. Please re-open your pull request against opendbc at your convenience by using this command below. This will transform all changes under selfdrive/car/ to opendbc_repo/opendbc/car/. Make sure you have initialized submodules beforehand and have checked out the latest opendbc commit.

PR_NUMBER=33045
curl -L https://github.com/commaai/openpilot/pull/$PR_NUMBER.patch | sed -e 's/selfdrive\/car/opendbc_repo\/opendbc\/car/g' | git apply -v --reject

Simply replace the PR number with your own. Once done, add the files, fix any conflicts, and open a new PR. Alternatively, you may start a new PR from scratch if that is easier for you.

@sshane sshane closed this Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants