Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VW: get VIN from camera without comma power #31851

Merged
merged 4 commits into from
Apr 8, 2024
Merged

VW: get VIN from camera without comma power #31851

merged 4 commits into from
Apr 8, 2024

Conversation

sshane
Copy link
Contributor

@sshane sshane commented Mar 13, 2024

Potentially needed for fingerprinting or car parameter setting

@jyoung8607 can you test this out?

@github-actions github-actions bot added the car vehicle-specific label Mar 13, 2024
@sshane
Copy link
Contributor Author

sshane commented Mar 14, 2024

Needs commaai/msgq#588

This works on camera and gateway harnesses as the camera is on bus 0 on both. A Golf R's camera returned negative response codes to KWP and OBD queries

@sshane sshane changed the title VW: add VIN address for camera-integrated users VW: get VIN for camera-integrated users without comma power Apr 8, 2024
@sshane sshane changed the title VW: get VIN for camera-integrated users without comma power VW: get VIN from camera without comma power Apr 8, 2024
@sshane sshane changed the title VW: get VIN from camera without comma power VW: get VIN from camera Apr 8, 2024
@sshane sshane changed the title VW: get VIN from camera VW: get VIN from camera without comma power Apr 8, 2024
@sshane sshane merged commit 22aa9a4 into master Apr 8, 2024
43 of 44 checks passed
@sshane sshane deleted the vw-camera-vin branch April 8, 2024 23:36
cydia2020 pushed a commit to cydia2020/dodgypilot that referenced this pull request May 14, 2024
* add VW camera to VIN addrs

* correct VW query

* consistent

* update refs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant