Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VW: check cruise control #32049

Merged
merged 5 commits into from
Mar 30, 2024
Merged

VW: check cruise control #32049

merged 5 commits into from
Mar 30, 2024

Conversation

sshane
Copy link
Contributor

@sshane sshane commented Mar 29, 2024

Each is only applicable in one of the two pcmCruise states, so only set when needed to be explicit.

@github-actions github-actions bot added car vehicle-specific volkswagen labels Mar 29, 2024
@sshane
Copy link
Contributor Author

sshane commented Mar 29, 2024

@jyoung8607 how does this look assuming we find the best signal for this?

BTW I have a slight preference for this one as we: 1) already check the message, 2) others are not higher rate, 3) we already understand this signal partially. The other possible signal is unlabeled and has no counter or checksum.

@sshane
Copy link
Contributor Author

sshane commented Mar 30, 2024

Haven't seen any speed limiter usage in our local rlogs last 360 days. Interestingly, cruise control mode also hasn't been seen until Discord user black_guru tested it for us. @jyoung8607 I assume if the car doesn't have ACC we throw a CAN error as there's no radar?

If that's the case, we can have a follow PR to handle the missing messages and instead set nonAdaptive (since the FW itself isn't enough to stop a non-ACC car from fingerprinting) 🙂

saving graph: /home/batman/status/1000_vw_check_nonadaptive.a2e5bff9-f606-4e49-9a17-d7bec8a91820.pickle
======== summary ========
success: 63976
skipped: 0
failed: 456
pending: 0
==== error messages =====
CarState (456/64432) 0.7%
  DataBadError: Car CAN data invalid (337)
  DataBadError: Couldn't determine online CarParams (47)
  TypeError: argument of type 'NoneType' is not iterable (67)
  Exception: Non-adaptive cruise control mode not supported (5)
====== error types ======
CarState (456/64432) 0.7%
  DataBadError:  (384)
  TypeError:  (67)
  Exception:  (5)
=========================
['CarState/9d09cc205c254c4b|00000000--8e49d0191f/31',
 'CarState/9d09cc205c254c4b|00000000--8e49d0191f/1',
 'CarState/9d09cc205c254c4b|00000000--8e49d0191f/27',
 'CarState/9d09cc205c254c4b|00000000--8e49d0191f/13',
 'CarState/9d09cc205c254c4b|00000000--8e49d0191f/21']

@sshane
Copy link
Contributor Author

sshane commented Mar 30, 2024

process replay diff is expected, the default value for unseen messages is always 0

@sshane sshane merged commit 493c810 into master Mar 30, 2024
31 of 32 checks passed
@sshane sshane deleted the vw-cc branch March 30, 2024 03:56
cydia2020 pushed a commit to cydia2020/dodgypilot that referenced this pull request May 14, 2024
* VW: check cruise control!

* fix that

* fix that

* Update ref_commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
car vehicle-specific volkswagen
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant