replay/framereader: no longer cache all AVPacket instances in memory #32236
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caching all
AVPacket
instances in memory can simplify the seeking to a specific frame, but it consumes significant memory resources, limits the scalability of theFrameReader
. especially when caching a greater number of segments inReplay
orCabana
. it can lead to increased memory usage, potentially causing performance issues or even system instability if memory resources are exhausted.This PR only stores the pkt_pos of each frame in memory. it uses
avio_seek
to seek to the frame's position, greatly reducing the memory footprint ofFrameReader
. It saves nearly 100MB of memory per segment for the road camera, with even greater savings when playing multiple cameras.It will be slightly slower than caching all AVPacket in memory, but since we have implemented frame prefetching in the camera thread, the performance gap is negligible.