Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cabana: refactor HistoryLog for simplification and enhancements #32284

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

deanlee
Copy link
Contributor

@deanlee deanlee commented Apr 23, 2024

This PR focus on simplifying the HistoryLog code, which has remained largely unchanged since its initial release and is quite messy. It also introducing several improvements:

  1. Time precision has been increased from two to three decimal places to match the precision used elsewhere in Cabana.
  2. Display meaningful value descriptors instead of raw values.
  3. Disable the export button when there is no data available.
    2024-04-23_22-43
  4. Fixed the issue where the initial active byte color values were incorrect after seeking.
  5. Fixed a bug where canFetchMore() incorrectly returned true when there was no more data available.
  6. Improved the performance of the fetchData() function.

Copy link
Contributor

github-actions bot commented Apr 23, 2024

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • the change is something we merge
    • include a route or your device' dongle ID if relevant

@github-actions github-actions bot added the tools label Apr 23, 2024
@deanlee deanlee changed the title cabana: refactor HistoryLog for for simplification and enhancements cabana: refactor HistoryLog for simplification and enhancements Apr 23, 2024
@adeebshihadeh adeebshihadeh merged commit 5e61775 into commaai:master Apr 23, 2024
39 checks passed
@deanlee deanlee deleted the cabana_cleanup_logview branch April 23, 2024 17:07
cydia2020 pushed a commit to cydia2020/dodgypilot that referenced this pull request May 14, 2024
Edison-CBS pushed a commit to Edison-CBS/openpilot that referenced this pull request Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants