cabana: Improve seeking and zooming #32334
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve https://github.com/commaai/openpilot/discussions/26091#discussioncomment-9289543 :
seekTo()
inChartsWidget::updateState()
to prevent drawing incorrect timelines inChart::updatePlot()
.The comparison after zooming in to 100 milliseconds (Real-time recording) :
before (Seems stuck because of camera blocking and incorrect updatePlot, though it's not truly hanging) :
Kazam_screencast_00145.webm
after:
Kazam_screencast_00144.webm