replay: add support for dcecompressing ZST log files #32910
Conversation
|
Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:
|
deanlee
changed the title
deanlee
force-pushed
the
replay_support_zst
branch
from
9d5476f to
f9d4adf
Compare
deanlee
force-pushed
the
replay_support_zst
branch
4 times, most recently
from
4602da8 to
ed969c9
Compare
|
@deanlee we're getting this merged soon, is this good to go? |
|
Yes, I've tested it and it's ready to go. However, there is still an issue with the selfdrive/PR comments. It can't find #include <zstd.h>. It seems we need to update the Docker image to include the zstd library. Do you have any ideas on how to resolve this? |
|
Looks like it's building the docker image from the base branch, which is expected to fail here. Hopefully we can clean up this job very soon, but I wouldn't make it a blocker for this PR. It should pass once we merge. |
tools/replay/logreader.cc
Outdated
| if (url.find(".bz2") != std::string::npos) { | ||
| data = decompressBZ2(data, abort); | ||
| } else if (url.find(".zst") != std::string::npos) { | ||
| data = decompressZST((std::byte *)data.data(), data.size(), abort); |
There was a problem hiding this comment.
Heads up we may remove the file extensions soon, so it should also detect from the file header like the python LogReader does.
deanlee
force-pushed
the
replay_support_zst
branch
from
ed969c9 to
79c8a82
Compare
|
The PR is ready, suggested changes have been applied. |
|
ty! |
* Add Support for Decompressing ZST Log Files * 2 space and check magic number * match BZ2 --------- Co-authored-by: Shane Smiskol <shane@smiskol.com> old-commit-hash: ade1372
No description provided.