ui: remove copy initialization of dialogs #33427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UI Screenshots
|
fredyshox
pushed a commit
that referenced
this pull request
Sep 4, 2024
remove copy initialization of dialogs old-commit-hash: dc06813
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates dialog-based objects to use direct initialization rather than copy initialization, aligning with Qt's design principles and preventing undefined behavior.
QWidget and its subclasses, including QDialog, are non-copyable: QWidget explicitly disables copying to avoid complications with the underlying GUI resource management. Attempting to copy these objects can lead to undefined behavior and resource management problems. Using direct initialization enhances code stability, ensures proper dialog handling, and reduces the risk of runtime errors.