process_replay: in-place modification for message migration #33695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sshane
reviewed
Oct 2, 2024
|
Down to 0.9 sec for rlog and 0.09 for qlog (from 2.5 and 0.3) |
UI PreviewAll Screenshots
|
|
@BBBmau looks like the open is inverted? |
cydia2020
pushed a commit
to cydia2020/dodgypilot
that referenced
this pull request
Oct 5, 2024
…33695) * Inplace modification of lr * Replace the original function * Add comment * Change the return type * Fix carParams retrieval * Remove the newline * Include carState migration * Remove TODO * Comment * List instead of gen * Fix deletion * Delete camera state if not valid * Update ref commit * Remove sorting at the end * Use migrate_all in ui report * Allow more control in what to migrate * Add type annotations * Static analysis * Improve type annot * Fix linter issues * Remove f-string * Migrate carState too in test_ui * Fix peripheralState migration * Sort at the end * Fix regen issue * Fix comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.