Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CarState: add invalidLkasSetting #33700

Merged
merged 9 commits into from
Oct 2, 2024
Merged

CarState: add invalidLkasSetting #33700

merged 9 commits into from
Oct 2, 2024

Conversation

sshane
Copy link
Contributor

@sshane sshane commented Oct 2, 2024 •
edited
Loading

Split from commaai/opendbc#1318

Also makes it a proper noEntry for Nissan, though since no one complained of a fault, I don't know if this even caused an issue. Will get testers later

@sshane sshane mentioned this pull request Oct 2, 2024
Merged
@sshane sshane changed the title Common lkas invalid alert CarState: add invalidLkasSetting Oct 2, 2024
@sshane
Copy link
Contributor Author

sshane commented Oct 2, 2024

Diff is just:

	('change', ['carState', 'events', 3, 'name'], ('lkasDisabledDEPRECATED', 'invalidLkasSetting'))
	('change', 'carState.invalidLkasSetting', (False, True))
	('change', ['carState', 'events', 1, 'name'], ('lkasDisabledDEPRECATED', 'invalidLkasSetting'))
	('change', 'carState.invalidLkasSetting', (False, True))
	('change', ['carState', 'events', 0, 'name'], ('lkasDisabledDEPRECATED', 'invalidLkasSetting'))
	('change', 'carState.invalidLkasSetting', (False, True))
...

LGTM

@sshane sshane merged commit 98e1d84 into master Oct 2, 2024
15 checks passed
@sshane sshane deleted the common-lkas-invalid-alert branch October 2, 2024 06:06
cydia2020 pushed a commit to cydia2020/dodgypilot that referenced this pull request Oct 5, 2024
@sshane @cydia2020
CarState: add invalidLkasSetting (commaai#33700)
20c281c 
* invalidLkasSetting

* clean up car specific a bit

* clean this up

* deprecate!

* bump

* this was just broken lol

* updaterefs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sshane