Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op sim: fix car steering angle #33718

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

op sim: fix car steering angle #33718

wants to merge 1 commit into from

Conversation

sshane
Copy link
Contributor

@sshane sshane commented Oct 3, 2024

selfdrived always is adding the turn exceeded warning without this

before:
image

after:
image

@github-actions github-actions bot added simulation running openpilot in environments like CARLA tools labels Oct 3, 2024
@sshane sshane changed the title op sim: fix read steering angle op sim: fix car steering angle Oct 3, 2024
@maxime-desroches
Copy link
Contributor

This adds some weird "swirling" when turning:

metadrive.mp4

@sshane
Copy link
Contributor Author

sshane commented Oct 3, 2024

This is because liveParameters is learning the offset ~equivelent to the angle. Also noticed the lateral control type is also set to torque despite the simulator being an angle car.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
simulation running openpilot in environments like CARLA tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants