Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

athenad: add threshold to update upload progress #34219

Conversation

deanlee
Copy link
Contributor

@deanlee deanlee commented Dec 12, 2024

  1. Introduces a threshold for updating upload progress, ensuring updates only occur when progress surpasses the threshold. This reduces unnecessary updates and minimizes lock contention on cur_upload_items.
  2. Removes the tid parameter from the callback function. Since the callback is always invoked within the do_upload thread, passing the current item directly enhances clarity and simplifies the code.

While it's uncertain whether this change directly resolves the recently reported issue of "slower upload queue listing and queuing," it remains a valuable improvement for reducing lock contention.

@deanlee deanlee force-pushed the athenad_add_threshold_to_progress_update branch from f512358 to 3f888a9 Compare December 12, 2024 19:23
@sshane
Copy link
Contributor

sshane commented Dec 12, 2024

While I appreciate you making these athena correctness changes, the original issue was to root cause the memory leak blocking release. There's been a bit too many subtle or real bugs from these changes, exacerbated by me not having enough time to test each one. Because of that, we should focus on the original issue at hand first instead of fixing real, but so far unnoticed thread safety issues hoping that they might fix the memory leak.

@sshane sshane closed this Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants