Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Single-wire GMLAN support #2

Closed
vntarasov opened this issue May 8, 2017 · 3 comments
Closed

Single-wire GMLAN support #2

vntarasov opened this issue May 8, 2017 · 3 comments

Comments

@vntarasov
Copy link
Contributor

I don't have access to create a pull request.

What the attached diff does:

  • Fixes off-by-one error in can bus speed calculation, that was preventing single-wire GMLAN from working on my Chevy Volt gen 2.
  • Makes it easier to understand, debug, and change the can speed configuration code.
  • Enables sending/receiving extended addresses (majority of messages on single-wire GMLAN on my car).

panda.patch.txt
@geohot
Copy link
Contributor

geohot commented May 9, 2017 •
edited
Loading

Hmm, what do you mean you don't have access? It should be public. Can you screenshot the page showing no access?

Reading the patch looks quite good though.

@geohot
Copy link
Contributor

geohot commented May 9, 2017

Oh not sure what you were trying, but I don't see a panda repo in your account.

In order to do a pull request, first fork the repo to your account. Then push your changes to the fork. Then click pull request. It should work.

@vntarasov
Copy link
Contributor Author

Yep, fork is what I missed. I talked to @edsammy earlier and he helped me realize that since I don't have push rights, I shouldn't try creating branches in the Panda repo directly, but fork it first, and create pull request from there. Will do that now.

wocsor referenced this issue in wocsor/panda Aug 11, 2018
@wocsor
fix checksum attempt #2
5d1a17d
robbederks added a commit that referenced this issue Oct 25, 2019
@robbederks
Linter fix #2
37a87ff
robbederks pushed a commit that referenced this issue Oct 25, 2019
@rbiasini @robbederks
Uno (#274)
a12a148 
* Added uno

* Added usb switch support

* Added PWM and IR power functions

* Implemented bootkick

* Added uno as a new hw type

* Bumped version

* Added fan control and tach readout

* WIP: RTC support

* Working RTC

* Fixed python

* Misra compliance

* Added USB control messages for fan/IR power

* Added USB commands + tests for fan & IR control. Fixed bootstub and pedal compilation

* Added IR and fan to power saving mode

* Changed defaults

* Fix safety considering uno

* passing safety now

* Minor UNO tweaks

* Fixed version

* More minor temporary tweaks

* Removed usb load switch from uno

* Added power control for shutting down the fan completely

* Disable IR LEDs by default

* Fixed linter issue

* Linter fix #2
robbederks added a commit that referenced this issue Apr 15, 2020
@robbederks
Fix imports #2
288c363
robbederks added a commit that referenced this issue Apr 16, 2020
@robbederks
Pedal gas pressed safety limits (#507)
0336f62 
* Fixed toyota pedal gas disengage and increased pedal limits to OP limits +5%

* Fix safety unit tests?

* Fix imports

* Fix imports #2
theantihero pushed a commit to theantihero/panda that referenced this issue Apr 24, 2020
@robbederks
Pedal gas pressed safety limits (commaai#507)
3db6910 
* Fixed toyota pedal gas disengage and increased pedal limits to OP limits +5%

* Fix safety unit tests?

* Fix imports

* Fix imports commaai#2
wirelessnet2 pushed a commit to wirelessnet2/panda that referenced this issue Nov 14, 2020
@robbederks @wirelessnet2
Pedal gas pressed safety limits (commaai#507)
8f22162 
* Fixed toyota pedal gas disengage and increased pedal limits to OP limits +5%

* Fix safety unit tests?

* Fix imports

* Fix imports commaai#2
wirelessnet2 pushed a commit to wirelessnet2/panda that referenced this issue Nov 15, 2020
@robbederks @wirelessnet2
Pedal gas pressed safety limits (commaai#507)
3382a87 
* Fixed toyota pedal gas disengage and increased pedal limits to OP limits +5%

* Fix safety unit tests?

* Fix imports

* Fix imports commaai#2
CT921 pushed a commit to DPCT921/panda that referenced this issue Oct 1, 2022
@rav4kumar
Merge pull request commaai#2 from commaai/master
49d31fc 
sync
JMPZ11 added a commit to opgm/panda that referenced this issue Nov 7, 2022
@Felger @JMPZ11
Need panda-side changes for the cancel button. Only really affects no…
a2b8814 
…n-pedal installs, I think. (commaai#2)

* Revert "disable power save"

This reverts commit eaf0db9.

* Update to prevent controls mismatch

Co-authored-by: jshuler <jshuler@gmail.com>
Coral-coder pushed a commit to Coral-coder/panda that referenced this issue Feb 20, 2023
@sunnyhaibin
Hyundai: Enhanced SCC (ESCC) Radar Interceptor support (commaai#2)
b65212a
briskspirit added a commit that referenced this issue Jun 20, 2023
@briskspirit
remove ELO #2
4c4fcd9
cydia2020 pushed a commit to cydia2020/panda that referenced this issue Jul 8, 2023
@wocsor
Merge pull request commaai#2 from ErichMoraga/smart_dsu
cc1661e 
Binaries corresponding with b5120f6
sheaduncan pushed a commit to sheaduncan/panda that referenced this issue Jul 29, 2024
@sunnyhaibin
MADS: Mazda: disallow resume if long control is not allowed (commaai#2)
506cb0b
@adeebshihadeh adeebshihadeh mentioned this issue Oct 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@geohot @vntarasov