Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable misra-c2012-10.3 #1852

Merged
merged 8 commits into from
Feb 18, 2024
Merged

Conversation

0x41head
Copy link
Contributor

@0x41head 0x41head commented Feb 5, 2024

For #1794

@0x41head
Copy link
Contributor Author

0x41head commented Feb 5, 2024

created PR to fix the bool issue in cppchecker
danmar/cppcheck#5948

@0x41head
Copy link
Contributor Author

0x41head commented Feb 6, 2024

my cppchecker PR has been merged.
@adeebshihadeh

@0x41head 0x41head marked this pull request as ready for review February 6, 2024 17:04
@adeebshihadeh
Copy link
Contributor

my cppchecker PR has been merged. @adeebshihadeh

Nice! Can you update the cppcheck version we install to pick up that update? It should be pinned to the commit you got merged.

@0x41head
Copy link
Contributor Author

0x41head commented Feb 6, 2024

Do I submit a new PR for that or can I make the changes in this PR?

@adeebshihadeh
Copy link
Contributor

Let's do a separate PR that just updates cppcheck.

@0x41head 0x41head mentioned this pull request Feb 7, 2024
@adeebshihadeh adeebshihadeh merged commit b4442a7 into commaai:master Feb 18, 2024
8 checks passed
eFiniLan added a commit to dragonpilot-community/panda that referenced this pull request Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants