Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling misra-c2012-2.5 #1900

Closed

Conversation

MarinkoMagla
Copy link
Contributor

For #1794

@dzid26
Copy link
Contributor

dzid26 commented May 22, 2024

I don't think it was rerun after the merge. After fixing LED colors compilation error there are still few violations.

** PANDA F4 CODE **
Checking /home/dzid_/openpilot/panda/board/main.c ...
Checking /home/dzid_/openpilot/panda/board/main.c: __GNUC__=9;PANDA=1;STM32F4=1;STM32F413xx=1...
/home/dzid_/openpilot/panda/board/boards/white.h:8:0: style: misra violation (use --rule-texts=<file> to get proper output) [misra-c2012-2.5]
#define CAN_MODE_GMLAN_CAN3 2U
^
/home/dzid_/openpilot/panda/board/boards/white.h:11:0: style: misra violation (use --rule-texts=<file> to get proper output) [misra-c2012-2.5]
#define CAN_MODE_GMLAN_CAN2 1U
^
/home/dzid_/openpilot/panda/board/faults.h:12:0: style: misra violation (use --rule-texts=<file> to get proper output) [misra-c2012-2.5]
#define FAULT_INTERRUPT_RATE_GMLAN          (1UL << 6)   // deprecated
^
/home/dzid_/openpilot/panda/board/faults.h:18:0: style: misra violation (use --rule-texts=<file> to get proper output) [misra-c2012-2.5]
#define FAULT_INTERRUPT_RATE_EXTI           (1UL << 22)
^
nofile:0:0: information: Active checkers: 280/837 (use --checkers-report=<filename> to see details) [checkersReport]

@dzid26 dzid26 mentioned this pull request May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants