Cppcheck 2.14 #1951
Merged
Cppcheck 2.14 #1951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
both arguments to memcmp() should be of compatible (matching) essential types
|
97b2ca8 was tested with panda by running recover.py twice (first time to flash bootstub, second time to see if it still jumps to dfu bootloader correctly) |
Avoid casting between pointer to void and an arithmetic type. Refactor bootloader address casting for easier understanding.
- force cppecheck tag fetch
|
To be sure I tested the bootloader function again by running recover.py twice. The new minor version of cppcheck just came out and caused fetching error when running test_misra.py. - I bumped the version and also added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades to Cppcheck 2.14 and fixes new violations that showed up after the upgrade.
Related #1794, #1954