Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subaru LKAS Angle safety model #2020

Closed
wants to merge 9 commits into from
Closed

Conversation

bravochar
Copy link

@bravochar bravochar commented Sep 13, 2024

Newer (3-camera) EyeSight systems need angle-based steering controls, which means new safety models. Most of this is lifted from jnewb1's abandoned branch.

The gist is that we're adding a new message and bus for the LKAS angle controls and using the Gen2 alt bus for most everything else.

@bravochar bravochar marked this pull request as draft September 13, 2024 15:53
@adeebshihadeh adeebshihadeh changed the title WIP: LKAS Angle safety model WIP: Subaru LKAS Angle safety model Sep 13, 2024
@martinl
Copy link
Contributor

martinl commented Sep 13, 2024

Thanks for the PR, this has been on my todo list too long

@bravochar bravochar changed the title WIP: Subaru LKAS Angle safety model Subaru LKAS Angle safety model Sep 13, 2024
@bravochar bravochar marked this pull request as ready for review September 13, 2024 20:32
@bravochar
Copy link
Author

I just rebased this so it's more up-to-date. My OpenDBC and OpenPilot PRs will be blocked until this is merged. Is there anything I'm missing here?

@sshane
Copy link
Contributor

sshane commented Feb 20, 2025

We've moved the car safety code into opendbc, please rebase and re-open your PR there!

@sshane sshane closed this Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants