Safety for Tesla Model 3 / Model Y #2036
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # board/safety/safety_tesla.h
lukasloetkolben
changed the title
# Conflicts: # board/safety/safety_tesla.h
- use DI_state as a standstill signal
gregjhogan
reviewed
Oct 15, 2024
| @@ -950,9 +950,9 @@ def test_not_allow_user_brake_when_moving(self, _user_brake_msg=None, get_brake_ | |||
| _user_brake_msg = self._user_brake_msg | |||
|
|
|||
| # Brake was already pressed | |||
| self._rx(self._vehicle_moving_msg(self.STANDSTILL_THRESHOLD)) | |||
There was a problem hiding this comment.
This was moved to match the ordering of test_allow_user_brake_at_zero_speed() and fixes this test failing due to the vehicle moving message being the same message as the cruise state message, so when we set the vehicle in motion it also calls pcm_cruise_check which changes controls_allowed.
* - match "vehicle_moving" with opendbc - allow to cancel * remove comment * update _vehicle_moving_msg * remove redundant condition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Tesla Model 3/Y
Prerequisite of: commaai/opendbc#1263