Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid svg id collisions in webpack svgr loader and vite svgr plugin #3332

Closed
wants to merge 2 commits into from

Conversation

ByronDWall
Copy link
Contributor

Fixes issue where svgo's cleanupIds default preset would cause id collisions between different svg files.

For more context see the svgo docs for cleanupIds, this svgo issue, and this mc-frontend PR.

…r-loader and vite-plugin-svgr in order to insure that there are no id collisions between svg files
Copy link

changeset-bot bot commented Dec 6, 2023

🦋 Changeset detected

Latest commit: 879cc18

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@commercetools-frontend/mc-scripts Patch
@commercetools-applications/merchant-center-template-starter-typescript Patch
@commercetools-applications/merchant-center-template-starter Patch
@commercetools-local/playground Patch
@commercetools-backend/eslint-config-node Patch
@commercetools-backend/express Patch
@commercetools-backend/loggers Patch
@commercetools-frontend/actions-global Patch
@commercetools-frontend/application-components Patch
@commercetools-frontend/application-config Patch
@commercetools-frontend/application-shell-connectors Patch
@commercetools-frontend/application-shell Patch
@commercetools-frontend/assets Patch
@commercetools-frontend/babel-preset-mc-app Patch
@commercetools-frontend/browser-history Patch
@commercetools-frontend/codemod Patch
@commercetools-frontend/constants Patch
@commercetools-frontend/create-mc-app Patch
@commercetools-frontend/cypress Patch
@commercetools-frontend/eslint-config-mc-app Patch
@commercetools-frontend/i18n Patch
@commercetools-frontend/jest-preset-mc-app Patch
@commercetools-frontend/jest-stylelint-runner Patch
@commercetools-frontend/l10n Patch
@commercetools-frontend/mc-dev-authentication Patch
@commercetools-frontend/mc-html-template Patch
@commercetools-frontend/notifications Patch
@commercetools-frontend/permissions Patch
@commercetools-frontend/react-notifications Patch
@commercetools-frontend/sdk Patch
@commercetools-frontend/sentry Patch
@commercetools-frontend/url-utils Patch
@commercetools-local/visual-testing-app Patch
@commercetools-website/custom-applications Patch
@commercetools-website/components-playground Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 6, 2023

Deploy preview for merchant-center-application-kit ready!

✅ Preview
https://merchant-center-application-4w0fx2xco-commercetools.vercel.app
https://appkit-sha-6079ff00873d3d5e8f908a0a817e50c5756cfa69.commercetools.vercel.app
https://appkit-pr-3332.commercetools.vercel.app

Built with commit 879cc18.
This pull request is being automatically deployed with vercel-action

Copy link
Contributor

github-actions bot commented Dec 6, 2023

Deploy preview for application-kit-custom-views ready!

✅ Preview
https://application-kit-custom-views-fy3upozu8-commercetools.vercel.app
https://appkit-cv-sha-6079ff00873d3d5e8f908a0a817e50c5756cfa69.commercetools.vercel.app
https://appkit-cv-pr-3332.commercetools.vercel.app

Built with commit 879cc18.
This pull request is being automatically deployed with vercel-action

Copy link
Member

@emmenko emmenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah wow, interesting. Thanks for finding a solution! 🙌

@emmenko
Copy link
Member

emmenko commented Dec 7, 2023

Closing in favor of #3334 (we couldn't figure out why some CI jobs are failing here).

@emmenko emmenko closed this Dec 7, 2023
@emmenko emmenko deleted the bw-avoid-svg-id-collisions branch December 7, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants