-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: avoid svg id collisions in webpack svgr loader and vite svgr plugin #3332
Conversation
…r-loader and vite-plugin-svgr in order to insure that there are no id collisions between svg files
🦋 Changeset detectedLatest commit: 879cc18 The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Deploy preview for merchant-center-application-kit ready! ✅ Preview Built with commit 879cc18. |
Deploy preview for application-kit-custom-views ready! ✅ Preview Built with commit 879cc18. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah wow, interesting. Thanks for finding a solution! 🙌
Closing in favor of #3334 (we couldn't figure out why some CI jobs are failing here). |
Fixes issue where
svgo
'scleanupIds
default preset would cause id collisions between different svg files.For more context see the svgo docs for cleanupIds, this svgo issue, and this mc-frontend PR.