Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: svgo plugin to use collision resistant IDs #3334

Merged
merged 2 commits into from
Dec 7, 2023

Conversation

emmenko
Copy link
Member

@emmenko emmenko commented Dec 7, 2023

Note

Original PR #3332 but somehow some CI jobs were failing there 🤷‍♂️

Fixes issue where svgo's cleanupIds default preset would cause id collisions between different svg files.

For more context see the svgo docs for cleanupIds, this svgo issue, and this mc-frontend PR.

ByronDWall and others added 2 commits December 7, 2023 12:28
…r-loader and vite-plugin-svgr in order to insure that there are no id collisions between svg files
Copy link

changeset-bot bot commented Dec 7, 2023

🦋 Changeset detected

Latest commit: 0c8eff7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 38 packages
Name Type
@commercetools-frontend/mc-scripts Patch
@commercetools-applications/merchant-center-template-starter-typescript Patch
@commercetools-applications/merchant-center-template-starter Patch
@commercetools-applications/merchant-center-custom-view-template-starter-typescript Patch
@commercetools-applications/merchant-center-custom-view-template-starter Patch
@commercetools-local/playground Patch
@commercetools-backend/eslint-config-node Patch
@commercetools-backend/express Patch
@commercetools-backend/loggers Patch
@commercetools-frontend/actions-global Patch
@commercetools-frontend/application-components Patch
@commercetools-frontend/application-config Patch
@commercetools-frontend/application-shell-connectors Patch
@commercetools-frontend/application-shell Patch
@commercetools-frontend/assets Patch
@commercetools-frontend/babel-preset-mc-app Patch
@commercetools-frontend/browser-history Patch
@commercetools-frontend/codemod Patch
@commercetools-frontend/constants Patch
@commercetools-frontend/create-mc-app Patch
@commercetools-frontend/cypress Patch
@commercetools-frontend/eslint-config-mc-app Patch
@commercetools-frontend/i18n Patch
@commercetools-frontend/jest-preset-mc-app Patch
@commercetools-frontend/jest-stylelint-runner Patch
@commercetools-frontend/l10n Patch
@commercetools-frontend/mc-dev-authentication Patch
@commercetools-frontend/mc-html-template Patch
@commercetools-frontend/notifications Patch
@commercetools-frontend/permissions Patch
@commercetools-frontend/react-notifications Patch
@commercetools-frontend/sdk Patch
@commercetools-frontend/sentry Patch
@commercetools-frontend/url-utils Patch
@commercetools-local/visual-testing-app Patch
@commercetools-website/custom-applications Patch
@commercetools-website/components-playground Patch
@commercetools-website/custom-views Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 7, 2023

Deploy preview for merchant-center-application-kit ready!

✅ Preview
https://merchant-center-application-6s23j4sce-commercetools.vercel.app
https://appkit-sha-0eb207ae2a1e092ea1fb016f9ad061540000074a.commercetools.vercel.app
https://appkit-pr-3334.commercetools.vercel.app

Built with commit 0c8eff7.
This pull request is being automatically deployed with vercel-action

@emmenko emmenko requested a review from tdeekens December 7, 2023 11:34
Copy link
Contributor

github-actions bot commented Dec 7, 2023

Deploy preview for application-kit-custom-views ready!

✅ Preview
https://application-kit-custom-views-866g87eoz-commercetools.vercel.app
https://appkit-cv-sha-0eb207ae2a1e092ea1fb016f9ad061540000074a.commercetools.vercel.app
https://appkit-cv-pr-3334.commercetools.vercel.app

Built with commit 0c8eff7.
This pull request is being automatically deployed with vercel-action

@emmenko
Copy link
Member Author

emmenko commented Dec 7, 2023

Merging as it was already approved in the other PR.

@emmenko emmenko merged commit 225c110 into main Dec 7, 2023
20 checks passed
@emmenko emmenko deleted the nm-fix-svg-id-collision branch December 7, 2023 11:35
@ct-changesets ct-changesets bot mentioned this pull request Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants