-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: svgo plugin to use collision resistant IDs #3334
Conversation
…r-loader and vite-plugin-svgr in order to insure that there are no id collisions between svg files
🦋 Changeset detectedLatest commit: 0c8eff7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 38 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Deploy preview for merchant-center-application-kit ready! ✅ Preview Built with commit 0c8eff7. |
Deploy preview for application-kit-custom-views ready! ✅ Preview Built with commit 0c8eff7. |
Merging as it was already approved in the other PR. |
Note
Original PR #3332 but somehow some CI jobs were failing there 🤷♂️
Fixes issue where
svgo
'scleanupIds
default preset would cause id collisions between different svg files.For more context see the svgo docs for cleanupIds, this svgo issue, and this mc-frontend PR.