-
-
Notifications
You must be signed in to change notification settings - Fork 281
Fix mypy check #156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mypy check #156
Conversation
Lee-W
commented
Apr 9, 2020
•
edited
Loading
edited
- style
- fix all the mypy warning
- config: move .flake8 to setup.cfg and add mypy, pytest config
- ci
- add mypy check
- add stricter config but comment out those we not yet follow
- remove redundant arugment (it's been configed in setup.cfg)
- test(cz/customize): add test case initialize_cz_customize_failed
Codecov Report
@@ Coverage Diff @@
## master #156 +/- ##
==========================================
+ Coverage 91.54% 91.58% +0.03%
==========================================
Files 33 33
Lines 769 784 +15
==========================================
+ Hits 704 718 +14
- Misses 65 66 +1
Continue to review full report at Codecov.
|
Thanks for taking the time to do this! |
@woile If other configurations look good to you, I'll merge this pull request late today 🙂 |
Yes it's fine 👍 if any of the new settings starts annoying we can discuss about changing it. |