-
-
Notifications
You must be signed in to change notification settings - Fork 281
refactor: set default_install_hook_types #697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
it needs #607 to be solved first as this requires at least 3.7 |
Thanks for the PR! Could you point this PR to |
done |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #697 +/- ##
==========================================
+ Coverage 97.37% 97.42% +0.04%
==========================================
Files 42 42
Lines 2022 2022
==========================================
+ Hits 1969 1970 +1
+ Misses 53 52 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Would you mind rebasing on top of |
isn't it already the case ? |
No, You can follow this instructions to rebase: #686 (comment) |
sorry I'm used to work in repositories where we squash merge PR so this is not considered as an issue. |
not sure I did the right thing but THB it's a super small modifcation. merge squash it it wil make everyone's life easier. Also the PR will look strange but upon merging, git resolves the duplicates commits (as they have the same hash) so why rebasing ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
Since pre-commit 2.18.0, it is possible to tell pre-commit which hook to install directly from the .pre-commit-config.yaml file. Thus I update the said file to apply the hooks according to the docs:
pre-commit install -t pre-commit -t pre-push -t commit-msg
. I also updated the pre-commit version to make sure this parameter is available and finally updated the contributing documentation to make sure people simply use thepre-commit install
command.bonus: there was a typo that I corrected (it's "stageS")
Checklist
./scripts/format
and./scripts/test
locally to ensure this change passes linter check and test