Skip to content

refactor: set default_install_hook_types #697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 23, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -112,4 +112,4 @@ venv.bak/
.DS_Store

# ruff
.ruff_cache
.ruff_cache
8 changes: 7 additions & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
default_install_hook_types:
- pre-commit
- commit-msg
- pre-push

default_stages:
- commit
- push

repos:
- repo: https://github.com/pre-commit/pre-commit-hooks
rev: v4.1.0
Expand Down Expand Up @@ -35,6 +41,6 @@ repos:
name: linter and test
language: system
pass_filenames: false
stage: push
stages: [push]
entry: ./scripts/test
types: [python]
2 changes: 1 addition & 1 deletion docs/contributing.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ If you're a first-time contributor, you can check the issues with [good first is
1. Fork [the repository](https://github.com/commitizen-tools/commitizen).
2. Clone the repository from your GitHub.
3. Setup development environment through [poetry](https://python-poetry.org/) (`poetry install`).
4. Setup [pre-commit](https://pre-commit.com/) hook (`poetry run pre-commit install -t pre-commit -t pre-push -t commit-msg`)
4. Setup [pre-commit](https://pre-commit.com/) hook (`poetry run pre-commit install`)
5. Check out a new branch and add your modification.
6. Add test cases for all your changes.
(We use [CodeCov](https://codecov.io/) to ensure our test coverage does not drop.)
Expand Down
2 changes: 1 addition & 1 deletion docs/getting_started.md
Original file line number Diff line number Diff line change
Expand Up @@ -116,4 +116,4 @@ Note that pre-commit discourages using `master` as a revision, and the above com
pre-commit autoupdate
```

Read more about the `check` command [here](check.md).
Read more about the `check` command [here](check.md).
4 changes: 2 additions & 2 deletions poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ pytest-xdist = "^3.1.0"
black = "^22.10"
# linter
ruff = "^0.0.262"
pre-commit = "^2.6.0"
pre-commit = "^2.18.0"
mypy = "^0.931"
types-PyYAML = "^5.4.3"
types-termcolor = "^0.1.1"
Expand Down