Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(prompter): refactor to allow granular consumption #25

Closed
wants to merge 3 commits into from

Conversation

jpnelson
Copy link

Break up the files to allow granular consumption of the changelog formatter / prompter

This closes #24

Break up the files to allow granular consumption of the changelog formatter / prompter

This closes commitizen#24
@jpnelson
Copy link
Author

Might be worth noting that this does not provide or remove any other functionality – it just refactors things so that files other than index.js can be depended upon to extend the conventional changelog format

@jimthedev
Copy link
Member

I'm thinking we'll make this a 2.0. Even though it isn't technically a breaking change, it will help us to signal to other adapter designers that they might need to do a major refactor. I need to test it a bit with the cli but overall I like the idea a lot and will likely merge. No timeline yet. Life is taking priority over oss right now. :)

@jpnelson
Copy link
Author

@jimthedev Any updates on this?

@jpnelson
Copy link
Author

I changed it so that it you can now override questions too. This would also be helpful for extending it.

@LinusU
Copy link
Contributor

LinusU commented Aug 14, 2016

Sorry for not looking into this earlier, do you think that your use case is solved by #29 and #30?

@LinusU
Copy link
Contributor

LinusU commented Jan 8, 2017

I think that this is solved by #30, closing for now...

@LinusU LinusU closed this Jan 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor the adapter to allow extension
3 participants