feat(adapter): refactor to engine, default to conventional commit types #30
Conversation
AndersDJohnson
force-pushed
the
engine-with-commit-types
branch
from
beeb191 to
b7a6ca0
Compare
AndersDJohnson
changed the title
|
|
||
| options = options || {}; | ||
|
|
||
| var types = objectAssign({}, options.types || conventionalCommitTypes.types); |
There was a problem hiding this comment.
Isn't it better to make this a required property, so that the engine doesn't need to depend on conventional-commit-types? I feel that that should be a dependency of cz-conventional-changelog?
AndersDJohnson
force-pushed
the
engine-with-commit-types
branch
from
b7a6ca0 to
56575d1
Compare
|
@LinusU Thanks, I've force pushed a refactor that:
|
| // fine. | ||
| module.exports = function (options) { | ||
|
|
||
| options = cloneDeep(options || {}); |
There was a problem hiding this comment.
Since we never modify options we don't need to clone it.
There was a problem hiding this comment.
@LinusU Sure, you seemed (rightly) concerned about modification, so this would protect us against any future changes that could modify.
AndersDJohnson
force-pushed
the
engine-with-commit-types
branch
from
56575d1 to
c8452d1
Compare
|
Thank you for the awesome contribution 🙌 I'm merging this now 👍 I don't know exactly how the transferring of the repo works, I think that you can go into settings and then transfer it. Then @jimthedev would have to accept it, and I think add you as a maintainer as well. Can you try that? |
|
@LinusU Thanks! I've just invited you and @jimthedev as collaborators on the GitHub repo. Then I tried to transfer to I added @jimthedev as an owner on the npm package, but I don't know your npm username, if you have one. |
|
I'm
|
|
@LinusU Added you as npm owner. For the repo, seems like either I'll have to transfer it to an admin of |
|
@LinusU You're now a co-owner of the organization. @adjohnson916 invite sent to become a member. @LinusU should have whatever access is needed to grant you the appropriate rights. |
|
Thanks @jimthedev! Well @LinusU I still cannot transfer repo to commitizen as I'm not an admin thereof. Shall I hand it off to you or Jim to promote, or do you want to make me an admin? |
|
Sorry, when I try to transfer, it still says "You don’t have admin rights to commitizen." Wonder if I have to be an owner? |
|
Funny that it should be so hard to transfer a repo 😆 Can you transfer it to me personally and I'll transfer it to the commitizen org and give you full rights to it? Thanks |
|
@LinusU I know, right? Transferred it to you. |
|
I'm so sorry for the delay on this, apparently I only had 24 hours to accept the transfer, and after I missed that deadline I completely dropped the ball on this. Sorry about that, if you want to try again I'll try to be more response :) |
|
@LinusU No worries. Transferred again. Please move the repo to the commitizen org. And maybe consider adding me as an admin there. Thanks! |
|
Should be fixed now 🎉 https://github.com/commitizen/conventional-commit-types |
Closes #29.
Changes due to relying on
conventional-commit-typesinclude addition of areverttype and some minor formatting changes in the prompter choices for types due to newlines & indentation being lost in type descriptions - I felt those were too specific to this use case to include in the types module.If merged, next step is to pull
engine.jsinto separate module per @LinusU at #29 (comment).I can give ownership of
conventional-commit-typesrepo tocommitizenand all the same npm owners as this module has.