Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Defaultable for CommandInputRecordField #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

tom-tan
Copy link
Member

@tom-tan tom-tan commented Dec 5, 2018

This is to solve common-workflow-language/common-workflow-language#641 by introducing a base type named Defaultable to the schema.

  • one or more conformance tests
  • testing with cwltool --enable-dev in a v1.1.0-dev1 document
    • add this test permanently
    • Okay, need to teach cwltool how to copy the default value over
    • update the spec
  • test cwltool using v1.0 and a record field default (this should fail)
    • add this test permanently

@mr-c mr-c requested a review from tetron December 5, 2018 10:21
@ghost ghost self-assigned this Jan 24, 2019
@ghost
Copy link

ghost commented Jan 24, 2019

@tom-tan we discussed this a bit and find the schema addition elegant. However there is a concern at the complexity implementation will entail. Could you please add (or point to) the cwltool implementation along with conformance tests, so we can discuss further. Thank you so much!

@tom-tan
Copy link
Member Author

tom-tan commented Aug 29, 2024

I made a re-done request to cwl-v1.3 (See common-workflow-language/cwl-v1.3#54).
Can I close this issue and continue it in common-workflow-language/cwl-v1.3#54?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deferred question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants