Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Defaultable for CommandInputRecordField #54

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

tom-tan
Copy link
Member

@tom-tan tom-tan commented Aug 29, 2024

This request is re-done of common-workflow-language/cwl-v1.1#20 to fix common-workflow-language/common-workflow-language#641.
I introduced Defaultable and made it a parent record of InputParameter, WorkflowStepInput and InputRecordField.
I also add a conformance test for it.

I changed the description of Defaultable#default by combining descriptions of InputParameter#default and WorkflowStepInput#default.
Please let me know if there are better descriptions to unifying other descriptions of the default field.

Here is a list to be done (copied from common-workflow-language/cwl-v1.1#20):

  • one or more conformance tests
  • testing with cwltool --enable-dev in a v1.3.0-dev1 document
    • add this test permanently
    • Okay, need to teach cwltool how to copy the default value over
    • update the spec
  • test cwltool using v1.0, v1.1 and v1.2 and a record field default (this should fail)
    • add this test permanently

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CommandInputRecordField needs default field
1 participant