Skip to content

Add helpful error message when a program is terminated by a (Unix) signal, such as a segfault #1569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mr-c merged 3 commits into from
Nov 24, 2021
Merged

Add helpful error message when a program is terminated by a (Unix) signal, such as a segfault #1569

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2223b09
Log warning if job fails
gmloose Nov 23, 2021
655d006
Reformat warning message
gmloose Nov 24, 2021
b4efd8f
Reformat code
gmloose Nov 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions cwltool/job.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import os
import re
import shutil
import signal
import stat
import subprocess # nosec
import sys
Expand Down Expand Up @@ -354,6 +355,13 @@ def _execute(
else:
processStatus = "permanentFail"

if processStatus != "success":
if rcode < 0:
_logger.warning("[job %s] was terminated by signal: %s", self.name,
signal.Signals(-rcode).name)
else:
_logger.warning("[job %s] exited with status: %d", self.name, rcode)

if "listing" in self.generatefiles:
if self.generatemapper:
relink_initialworkdir(
Expand Down