Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conformance testing: switch to pytest + cwltest #1783

Merged
merged 2 commits into from
Jan 9, 2023
Merged

conformance testing: switch to pytest + cwltest #1783

merged 2 commits into from
Jan 9, 2023

Conversation

mr-c
Copy link
Member

@mr-c mr-c commented Jan 9, 2023

  1. Usethe cwltest plugin for pytest
  2. Simplify the Singularity install
  3. Simplify the release test (saved 17 minutes for that run)

All together this speeds up the entire GitHub Actions CI run.

Previously the overall wall time was 29 minutes 22 seconds

Now 14 minutes 43 seconds

Specific speed ups:

@codecov
Copy link

codecov bot commented Jan 9, 2023

Codecov Report

Merging #1783 (d797ad4) into main (955616b) will increase coverage by 0.67%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1783      +/-   ##
==========================================
+ Coverage   82.51%   83.19%   +0.67%     
==========================================
  Files          47       44       -3     
  Lines        8209     8130      -79     
  Branches     2237     2224      -13     
==========================================
- Hits         6774     6764      -10     
+ Misses        941      874      -67     
+ Partials      494      492       -2     
Impacted Files Coverage Δ
cwltool/main.py 73.98% <0.00%> (-1.84%) ⬇️
cwltool.py
cwltool/run_job.py
gittaggers.py
cwltool/singularity.py 70.56% <0.00%> (+4.76%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mr-c mr-c force-pushed the cwltest-pytest branch 7 times, most recently from da0f855 to 6ecc3e0 Compare January 9, 2023 12:50
@mr-c mr-c marked this pull request as ready for review January 9, 2023 13:11
@mr-c mr-c enabled auto-merge (rebase) January 9, 2023 13:50
@mr-c mr-c disabled auto-merge January 9, 2023 13:52
@mr-c mr-c merged commit dbc4c4c into main Jan 9, 2023
@mr-c mr-c deleted the cwltest-pytest branch January 9, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant