Fix fast container job hangs

[kuanyili]

Starting from Podman 4.4.0, cidfile is removed along with the container.

Always return if container is terminated so we don't stuck in the loop waiting for a file which has already been removed.

Fixes: #1961

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9b5a6ea) 83.80% compared to head (399b9db) 83.80%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1962   +/-   ##
=======================================
  Coverage   83.80%   83.80%           
=======================================
  Files          46       46           
  Lines        8221     8221           
  Branches     2182     2182           
=======================================
  Hits         6890     6890           
- Misses        852      854    +2     
+ Partials      479      477    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[kuanyili]

Hmm.... It's strange that such a small change triggers this many CI errors.

Some udocker jobs are failing but the change is in docker_monitor which is a function NOT used by udocker jobs. On the other hand, this patch runs well on my machine and fixed the aforementioned issue beautifully.

The CI error pattern is very similar to that in the most recent PR #1960. Maybe they're related?

[mr-c]

Thanks for alerting me to that @kuanyili ; I think I fixed the udocker problem