Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the --shm-size parameter at runtime #1972

Merged
merged 3 commits into from
Feb 1, 2024

Conversation

lihl2014
Copy link
Contributor

@lihl2014 lihl2014 commented Jan 29, 2024

@mr-c
Copy link
Member

mr-c commented Jan 29, 2024

Thank you for this @lihl2014 ; do you know what the equivalent options for podman and singularity/apptainer are?

@mr-c
Copy link
Member

mr-c commented Jan 29, 2024

For podman, looks like it has the same option name: --shm-size ; but for apptainer/singularity there doesn't seem to be such an option

https://docs.podman.io/en/latest/markdown/podman-run.1.html#shm-size-number-unit

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (fe1e8a9) 83.75% compared to head (6c254b0) 83.80%.

Files Patch % Lines
cwltool/singularity.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1972      +/-   ##
==========================================
+ Coverage   83.75%   83.80%   +0.04%     
==========================================
  Files          46       46              
  Lines        8231     8235       +4     
  Branches     2186     2187       +1     
==========================================
+ Hits         6894     6901       +7     
+ Misses        860      858       -2     
+ Partials      477      476       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mr-c mr-c force-pushed the shm-size#1821 branch 2 times, most recently from 593088f to 2753b27 Compare January 31, 2024 12:58
@mr-c mr-c enabled auto-merge (squash) January 31, 2024 12:59
@mr-c
Copy link
Member

mr-c commented Jan 31, 2024

Thank you @lihl2014 !

@mr-c mr-c changed the title add the --shm-size parameter at runtime #1821 add the --shm-size parameter at runtime Jan 31, 2024
@mr-c mr-c disabled auto-merge January 31, 2024 12:59
@mr-c mr-c enabled auto-merge (squash) January 31, 2024 13:00
@mr-c mr-c disabled auto-merge February 1, 2024 15:52
@mr-c mr-c merged commit 7b8f174 into common-workflow-language:main Feb 1, 2024
44 of 45 checks passed
@lihl2014 lihl2014 deleted the shm-size#1821 branch February 2, 2024 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to add the -- shm-size parameter at runtime
2 participants