Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated outputMethod values #2042

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Updated outputMethod values #2042

merged 1 commit into from
Sep 18, 2024

Conversation

GlassOfWhiskey
Copy link
Contributor

Updated outputMehtod values to last_iteration and all_iterations, according to common-workflow-language/cwl-v1.3#5.

@GlassOfWhiskey GlassOfWhiskey force-pushed the rename-loop-output-method branch from 650f4c4 to 5566827 Compare September 18, 2024 10:26
cwltool/update.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.78%. Comparing base (4bb5329) to head (b3edc09).
Report is 38 commits behind head on main.

Files with missing lines Patch % Lines
cwltool/workflow_job.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2042      +/-   ##
==========================================
- Coverage   83.80%   83.78%   -0.02%     
==========================================
  Files          46       46              
  Lines        8267     8270       +3     
  Branches     2201     2202       +1     
==========================================
+ Hits         6928     6929       +1     
- Misses        858      861       +3     
+ Partials      481      480       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mr-c
Copy link
Member

mr-c commented Sep 18, 2024

make dev cleanup please ☺️

@GlassOfWhiskey GlassOfWhiskey force-pushed the rename-loop-output-method branch 2 times, most recently from 0aafd67 to d22c4a9 Compare September 18, 2024 12:44
@GlassOfWhiskey GlassOfWhiskey force-pushed the rename-loop-output-method branch from d22c4a9 to b3edc09 Compare September 18, 2024 12:48
@mr-c mr-c merged commit 55ccde7 into main Sep 18, 2024
49 of 50 checks passed
@mr-c mr-c deleted the rename-loop-output-method branch September 18, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants