10827 static checker fix #435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
lijiayong
changed the title
Member
|
Jenkins, add to test list |
Member
|
Jenkins, add to testlist |
Member
|
Can you take a look at the bug demonstrated here? common-workflow-language/common-workflow-language#462 |
Contributor
Author
|
Sure, looking |
Member
|
See also #437 |
added 3 commits
June 22, 2017 17:41
…when linkMerge is merge_flattened and srctype is a list
Contributor
Author
|
I think this fixes issue #437. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix to the following bug when the source has linkMerge and sink is "Any". For example,
echo.cwl
cwlVersion: v1.0 class: CommandLineTool baseCommand: echo inputs: echo_in: type: Any inputBinding: {} outputs: []echo-wf.cwl
class: Workflow cwlVersion: v1.0 requirements: MultipleInputFeatureRequirement: {} inputs: letters0: type: string default: "a0" letters1: type: string[] default: ["a1", "b1"] outputs: [] steps: echo: run: echo.cwl in: echo_in: source: [letters0, letters1] linkMerge: merge_nested out: []Executing the workflow gives the following error.
$ cwltool echo-wf.cwl /home/jiayong/anaconda2/bin/cwltool 1.0.20170616035942 Resolved 'echo-wf.cwl' to 'file:///home/jiayong/Code/work_scripts/cwl/test/echo_any/echo-wf.cwl' Tool definition failed validation: echo-wf.cwl:7:5: Source 'letters0' of type "string" is incompatible echo-wf.cwl:19:7: with sink 'echo_in' of type "Any" echo-wf.cwl:19:7: sink has linkMerge method merge_nested echo-wf.cwl:10:5: Source 'letters1' of type {"type": "array", "items": "string"} is incompatible echo-wf.cwl:19:7: with sink 'echo_in' of type "Any" echo-wf.cwl:19:7: sink has linkMerge method merge_nested