Remove unused functions

[tom-tan]

By introducing tree structure exceptions, several functions and several function parameters are no longer used.
This request removes the following.

• reformat_yaml_exception_message
  • No longer needed because the exceptions from ruamel parser are wrapped with SchemaSaladException
• regex_chunk, chunk_messages, indent, bullets, strip_dup_lineno in sourceline.py
  • They are replaced with strip_duplicated_lineno, reflow_all, and SchemaSaladException#pretty_str
• SourceLine#__enter__, SourceLine#__exit__, SourceLine#makeError
  • They are replaced with a simple exception handling
• raise_type and include_traceback from the constructor of SourceLine
  • Now exceptions are thrown from outside of SourceLine

[codecov]

Codecov Report

Merging #295 into master will increase coverage by 1.10%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #295      +/-   ##
==========================================
+ Coverage   68.50%   69.61%   +1.10%     
==========================================
  Files          15       15              
  Lines        2848     2797      -51     
  Branches      776      764      -12     
==========================================
- Hits         1951     1947       -4     
+ Misses        721      674      -47     
  Partials      176      176              

Impacted Files	Coverage Δ
schema_salad/sourceline.py	70.89% <ø> (+13.39%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93cdd36...aea9e3b. Read the comment docs.

[mr-c]

This breaks cwltool so the version number in setup.py needs to be increased

ImportError: cannot import name 'strip_dup_lineno' from 'schema_salad.sourceline' (/home/michael/schema_salad/schema_salad/sourceline.py)

[mr-c]

A failure from another part of cwltool is

>               with SourceLine(obj, "location", validate.ValidationException, _logger.isEnabledFor(logging.DEBUG)):
E               TypeError: __init__() takes from 2 to 3 positional arguments but 5 were given

Can this be avoided?

[tom-tan]

OK, I will send a PR to cwltool.

[tom-tan]

I found that the exceptions in cwltool are not structured...
But I leave it as is because it is out of scope of fixing the issue.

[tom-tan]

@mr-c Can I change this request to remove reformat_yaml_exception_message, regex_chunk and chunk_messages?

I found that this request includes two types of unused functions:

• No longer used both of schema_salad and cwltool: reformat_yaml_exception_message, regex_chunk and chunk_messages

• schema_salad does not use but cwltool uses:

  • indent, bullets, strip_dup_lineno
  • SourceLine#__enter__, SourceLine#__exit__, and SourceLine#makeError

We can safely remove the former but currently it is difficult to remove the latter because they are mainly used to reformat the exception messages. To remove them, it is better to move the exceptions in cwltool to tree structured exceptions but it needs more work than this request want to do.

[mr-c]

Can I change this request to remove reformat_yaml_exception_message, regex_chunk and chunk_messages?

yes

[tom-tan]

Done! Now this request only removes reformat_yaml_exception_message, regex_chunk and chunk_messages.

I dismiss it because now strip_dup_lineno is not removed.

[mr-c]

Thanks!