-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move logging messages to exceptions #296
Conversation
Codecov Report
@@ Coverage Diff @@
## master #296 +/- ##
==========================================
+ Coverage 69.53% 69.61% +0.07%
==========================================
Files 15 15
Lines 2797 2797
Branches 764 764
==========================================
+ Hits 1945 1947 +2
Misses 674 674
+ Partials 178 176 -2
Continue to review full report at Codecov.
|
This PR results in 3 test_default_path, test_pack_fragment, and test_pack_rewrites https://gist.github.com/mr-c/f2fd2a9cb60700176fe23a370d7e5edb |
In addition, CWL v1.0/v1.1 conformance test # 54 fails: "hints_unknown_ignored: Test unknown hints are ignored" |
Thank you for your comment but I close this issue because the current behavior is correct. In the above example, The above output shows: warnings about By the way, the current output gets us confusing a little because it seems to be a mis-ordering of errors. /Users/tom-tan/.pyenv/versions/3.8.0/bin/schema-salad-tool Current version: 4.3.20190604170443
Warning: ../../error.cwl:11:5: checking item
../../error.cwl:11:5: Field `class` contains undefined reference to `file:///Users/tom-tan/DockerRequirementXX`
Warning: ../../error.cwl:40:7: Field `location` contains undefined reference to `file:///Users/tom-tan/args.py`
Document `/Users/tom-tan/error.cwl` failed validation:
../../error.cwl:3:1: Field `cwlVersion` contains undefined reference to `file:///Users/tom-tan/v1.0a` Any thoughts? |
Correct
Where are you seeing
I like the "Warning" prefix, can you send a PR? |
#!/usr/bin/env cwl-runner
cwlVersion: v1.0a # Here! It will be an error because `v1.0a` is not valid
OK, I will make it! |
Some errors are treated as warning that cannot be caught as exceptions.
This request fixes this issue by rethrowing the exception instead of just printing.
Example input:
4.3.20190604170443
but I obtained the same result in latest, i.e.,4.5.20191023134839
)