check for both UnionSchema and NamedUnionSchema #846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tetron
force-pushed
the
named-map-union-fix
branch
from
0f9d539 to
fe0125e
Compare
tetron
force-pushed
the
named-map-union-fix
branch
from
fe0125e to
221aa7b
Compare
tetron
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #846 +/- ##
=======================================
Coverage 83.37% 83.37%
=======================================
Files 22 22
Lines 4813 4813
Branches 1302 1302
=======================================
Hits 4013 4013
Misses 526 526
Partials 274 274 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NamedUnionSchema isn't a subclass of UnionSchema, and the first thing I tried (making NamedUnionSchema a subclass of both UnionSchema and NamedSchema) didn't work because mypyc didn't like multiple inheritance.
This should fix common-workflow-language/cwltool#1779