Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check for both UnionSchema and NamedUnionSchema #846

Merged
merged 1 commit into from
Jul 10, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions schema_salad/validate.py
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ def friendly(v: Any) -> Any:
return f"array of <{friendly(v.items)}>"
if isinstance(v, avro.schema.PrimitiveSchema):
return v.type
if isinstance(v, avro.schema.UnionSchema):
if isinstance(v, (avro.schema.UnionSchema, avro.schema.NamedUnionSchema)):
return " or ".join([friendly(s) for s in v.schemas])
return avro_shortname(v)

Expand Down Expand Up @@ -235,7 +235,7 @@ def validate_ex(
f"expected list of {friendly(expected_schema.items)}"
)
return False
if isinstance(expected_schema, avro.schema.UnionSchema):
if isinstance(expected_schema, (avro.schema.UnionSchema, avro.schema.NamedUnionSchema)):
for s in expected_schema.schemas:
if validate_ex(
s,
Expand Down
Loading