Fix simple warnings #1097
Merged
Fix simple warnings #1097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Widget
This commit fixes warnings like the following:
/path/to/CTK/Libs/Widgets/ctkWorkflowButtonBoxWidget.cpp:200:72: warning: ‘static QSet<T> QSet<T>::fromList(const QList<T>&) [with T = ctkWorkflowStep*]’ is deprecated: Use QSet<T>(list.begin(), list.end()) instead. [-Wdeprecated-declarations]
200 | QSet<ctkWorkflowStep*>::fromList(this->GoToButtonToStepMap.values());
| ^
This commit fixes warnings like the following:
/path/to/CTK/Plugins/org.commontk.dah.core/ctkSoapConnectionRunnable.cpp:146:27: warning: ‘QByteArray& QByteArray::append(const QString&)’ is deprecated: Use QString's toUtf8(), toLatin1() or toLocal8Bit() [-Wdeprecated-declarations]
146 | block.append(content);
| ^
…eSQL
This commit fixes the following warning:
/path/to/CTK/Libs/PluginFramework/ctkPluginStorageSQL.cpp:737:46: warning: ‘int QSqlError::number() const’ is deprecated [-Wdeprecated-declarations]
737 | int result = query->lastError().number();
| ^
This commit fixes the following warning:
/path/to/CTK/Applications/ctkCommandLineModuleExplorer/ctkCommandLineModuleExplorerMain.cpp:146:47: warning: ‘QByteArray& QByteArray::append(const QString&)’ is deprecated: Use QString's toUtf8(), toLatin1() or toLocal8Bit() [-Wdeprecated-declarations]
146 | byteArray.append(args["string"].toString());
| ^
This commit fixes warnings like the following:
/path/to/CTK/Libs/PluginFramework/ctkPluginStorageSQL.cpp:699:23: warning: ‘QList<T> QSet<T>::toList() const [with T = QString]’ is deprecated: Use values() instead. [-Wdeprecated-declarations]
699 | return paths.toList();
| ^
…wser
This commit fixes the following warning:
/path/to/CTK/Libs/DICOM/Widgets/ctkDICOMBrowser.cpp:1633:45: warning: ‘QFileDialog::DirectoryOnly’ is deprecated: Use setOption(ShowDirsOnly, true) instead [-Wdeprecated-declarations]
1633 | directoryDialog->setFileMode(QFileDialog::DirectoryOnly);
| ^~~~~~~~~~~~~
This commit fixes warnings like the following:
/path/to/CTK/Libs/DICOM/Widgets/ctkDICOMTableView.cpp:358:49: warning: ‘void QList<T>::swap(int, int) [with T = int]’ is deprecated: Use QList<T>::swapItemsAt() [-Wdeprecated-declarations]
358 | columnIndicesByVisualIndex.swap(j, j+1);
| ^
This commit fixes the following warning:
/path/to/CTK/Libs/DICOM/Widgets/Testing/Cpp/ctkDICOMBrowserTest.cpp:79:49: warning: ‘QDir& QDir::operator=(const QString&)’ is deprecated: Use QDir::setPath() instead [-Wdeprecated-declarations]
79 | this->DICOMDir = dataDir.filePath("Data/DICOM");
| ^
…ogTest1
This commit fixes the following warning:
/path/to/CTK/Libs/Widgets/Testing/Cpp/ctkFileDialogTest1.cpp:47:40: warning: ‘QFileDialog::DirectoryOnly’ is deprecated: Use setOption(ShowDirsOnly, true) instead [-Wdeprecated-declarations]
47 | fileDialog->setFileMode(QFileDialog::DirectoryOnly);
| ^~~~~~~~~~~~~
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.