Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix simple warnings #1097

Merged
merged 9 commits into from
Jun 14, 2023
Merged

Fix simple warnings #1097

merged 9 commits into from
Jun 14, 2023

Commits on Jun 14, 2023

  1. COMP: Fix deprecated use of QSet<T>::toList() in ctkWorkflowButtonBox… 

    …Widget

This commit fixes warnings like the following:

/path/to/CTK/Libs/Widgets/ctkWorkflowButtonBoxWidget.cpp:200:72: warning: ‘static QSet<T> QSet<T>::fromList(const QList<T>&) [with T = ctkWorkflowStep*]’ is deprecated: Use QSet<T>(list.begin(), list.end()) instead. [-Wdeprecated-declarations]
  200 |     QSet<ctkWorkflowStep*>::fromList(this->GoToButtonToStepMap.values());
      |                                                                        ^
    @jcfr
    jcfr committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    64bd18a View commit details
    Browse the repository at this point in the history

  2. COMP: Fix -Wdeprecated-declarations in ctkSoapConnectionRunnable 

    This commit fixes warnings like the following:

/path/to/CTK/Plugins/org.commontk.dah.core/ctkSoapConnectionRunnable.cpp:146:27: warning: ‘QByteArray& QByteArray::append(const QString&)’ is deprecated: Use QString's toUtf8(), toLatin1() or toLocal8Bit() [-Wdeprecated-declarations]
  146 |       block.append(content);
      |                           ^
    @jcfr
    jcfr committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    e4ed0d6 View commit details
    Browse the repository at this point in the history

  3. COMP: Remove deprecated use of QSqlError::number() in ctkPluginStorag… 

    …eSQL

This commit fixes the following warning:

/path/to/CTK/Libs/PluginFramework/ctkPluginStorageSQL.cpp:737:46: warning: ‘int QSqlError::number() const’ is deprecated [-Wdeprecated-declarations]
  737 |       int result = query->lastError().number();
      |                                              ^
    @jcfr
    jcfr committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    ae800b8 View commit details
    Browse the repository at this point in the history

  4. COMP: Fix -Wdeprecated-declarations in ctkCommandLineModuleExplorerMain 

    This commit fixes the following warning:

/path/to/CTK/Applications/ctkCommandLineModuleExplorer/ctkCommandLineModuleExplorerMain.cpp:146:47: warning: ‘QByteArray& QByteArray::append(const QString&)’ is deprecated: Use QString's toUtf8(), toLatin1() or toLocal8Bit() [-Wdeprecated-declarations]
  146 |     byteArray.append(args["string"].toString());
      |                                               ^
    @jcfr
    jcfr committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    a24f509 View commit details
    Browse the repository at this point in the history

  5. COMP: Fix deprecated use of QSet<T>::toList() in ctkPluginStorageSQL 

    This commit fixes warnings like the following:

/path/to/CTK/Libs/PluginFramework/ctkPluginStorageSQL.cpp:699:23: warning: ‘QList<T> QSet<T>::toList() const [with T = QString]’ is deprecated: Use values() instead. [-Wdeprecated-declarations]
  699 |   return paths.toList();
      |                       ^
    @jcfr
    jcfr committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    0af7a87 View commit details
    Browse the repository at this point in the history

  6. COMP: Fix deprecated use of QFileDialog::DirectoryOnly in ctkDICOMBro… 

    …wser

This commit fixes the following warning:

/path/to/CTK/Libs/DICOM/Widgets/ctkDICOMBrowser.cpp:1633:45: warning: ‘QFileDialog::DirectoryOnly’ is deprecated: Use setOption(ShowDirsOnly, true) instead [-Wdeprecated-declarations]
 1633 |   directoryDialog->setFileMode(QFileDialog::DirectoryOnly);
      |                                             ^~~~~~~~~~~~~
    @jcfr
    jcfr committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    8bc4483 View commit details
    Browse the repository at this point in the history

  7. COMP: Fix deprecated use of QList::swap() in ctkDICOMTableView 

    This commit fixes warnings like the following:

/path/to/CTK/Libs/DICOM/Widgets/ctkDICOMTableView.cpp:358:49: warning: ‘void QList<T>::swap(int, int) [with T = int]’ is deprecated: Use QList<T>::swapItemsAt() [-Wdeprecated-declarations]
  358 |           columnIndicesByVisualIndex.swap(j, j+1);
      |                                                 ^
    @jcfr
    jcfr committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    8ebac34 View commit details
    Browse the repository at this point in the history

  8. COMP: Fix -Wdeprecated-declarations in ctkDICOMBrowserTester 

    This commit fixes the following warning:

/path/to/CTK/Libs/DICOM/Widgets/Testing/Cpp/ctkDICOMBrowserTest.cpp:79:49: warning: ‘QDir& QDir::operator=(const QString&)’ is deprecated: Use QDir::setPath() instead [-Wdeprecated-declarations]
   79 |   this->DICOMDir = dataDir.filePath("Data/DICOM");
      |                                                 ^
    @jcfr
    jcfr committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    22bc651 View commit details
    Browse the repository at this point in the history

  9. COMP: Fix deprecated use of QFileDialog::DirectoryOnly in ctkFileDial… 

    …ogTest1

This commit fixes the following warning:

/path/to/CTK/Libs/Widgets/Testing/Cpp/ctkFileDialogTest1.cpp:47:40: warning: ‘QFileDialog::DirectoryOnly’ is deprecated: Use setOption(ShowDirsOnly, true) instead [-Wdeprecated-declarations]
   47 |   fileDialog->setFileMode(QFileDialog::DirectoryOnly);
      |                                        ^~~~~~~~~~~~~
    @jcfr
    jcfr committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    ead9fb9 View commit details
    Browse the repository at this point in the history