-
Notifications
You must be signed in to change notification settings - Fork 86
COMP: Fix build against Qt 4.8 #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This failed to compile in the precompiled. moc_PythonQtStdDecorators.cpp. This function seems to be only stub so removing it.
Tested this on my Linux build with Qt 4.6.3. Works fine. |
Compiles on win7/msvc2008/python2.7/qt4.8 with patch. Had to disable XmlPatterns wrapper though. |
This patch worked for me too against 4.8.1 on linux. I don't see any contact information on the PythonQt website. Does anyone know who to contact? |
Hi Folks, Upstream PythonQt (aka Florian) has integrated our patches to enable He also added a mechanism allowing to registered external wrapping mechanism (i.e. VTK). See r206) In addition to various bug fixes, support for Qt 4.8 has also been added upstream (See r213 and r226) Given these information, here is the plan:
Let me know what you all think ? Jc |
Thanks for your work on this! I'm late to the show, but for my information; if the CMake changes have been merged upstream, what will be the difference between patched-2 and upstream HEAD? Thanks, |
Hi @thewtex, Good point. Hopefully, it shouldn't be needed. I am just anticipating some possible specific tweak before backporting changes upstream. Next week, I will be in Boston for the CTK hackfest and i will be working on that. Jc |
Cool! On Wed, Jul 4, 2012 at 9:16 PM, Jean-Christophe Fillion-Robin
|
Excellence. On Tue, Jul 10, 2012 at 9:15 PM, Jean-Christophe Fillion-Robin
|
…vendor-submodules ignore files
Support Qt 5.12
This failed to compile in the
precompiled. moc_PythonQtStdDecorators.cpp. This function seems to be
only stub so removing it.