Skip to content

COMP: Fix build against Qt 4.8 #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

johan-andruejol
Copy link

This failed to compile in the
precompiled. moc_PythonQtStdDecorators.cpp. This function seems to be
only stub so removing it.

This failed to compile in the
precompiled. moc_PythonQtStdDecorators.cpp.  This function seems to be
only stub so removing it.
@patmarion
Copy link
Member

Tested this on my Linux build with Qt 4.6.3. Works fine.

@jeinarsson
Copy link

Compiles on win7/msvc2008/python2.7/qt4.8 with patch. Had to disable XmlPatterns wrapper though.

@thewtex
Copy link

thewtex commented Jul 4, 2012

This patch worked for me too against 4.8.1 on linux.

I don't see any contact information on the PythonQt website. Does anyone know who to contact?

@jcfr
Copy link
Member

jcfr commented Jul 4, 2012

Hi Folks,

Upstream PythonQt (aka Florian) has integrated our patches to enable CMake based build. (See r200, r201, r202, r204, r205)

He also added a mechanism allowing to registered external wrapping mechanism (i.e. VTK). See r206)

In addition to various bug fixes, support for Qt 4.8 has also been added upstream (See r213 and r226)

Given these information, here is the plan:

  • To ensure that existing project relying on the patched branch can be built against CTK/PythonQt, the patched branch will be kept as it is.
  • A new branch named patched-2 will be added, it will be based on the most recent PythonQt (very probably r228)
  • Regarding the glue code enabling the use of PythonQt with VTK based project. I envision two options:
    ** Add it inside CTK itself (under Libs/Scripting/Python/Core or Libs/Visualization/VTK/Scripting.
    ** Create a separate project named for example PythonQtVTKWrapper that will host the code.

Let me know what you all think ?

Jc

@thewtex
Copy link

thewtex commented Jul 4, 2012

Let me know what you all think ?

Thanks for your work on this!

I'm late to the show, but for my information; if the CMake changes have been merged upstream, what will be the difference between patched-2 and upstream HEAD?

Thanks,
Matt

@jcfr
Copy link
Member

jcfr commented Jul 4, 2012

Hi @thewtex,

Good point. Hopefully, it shouldn't be needed. I am just anticipating some possible specific tweak before backporting changes upstream. patched-2 could be seen as a staging area before the change are integrated into the official repo.

Next week, I will be in Boston for the CTK hackfest and i will be working on that.

Jc

@thewtex
Copy link

thewtex commented Jul 4, 2012

Cool!

On Wed, Jul 4, 2012 at 9:16 PM, Jean-Christophe Fillion-Robin
reply@reply.github.com
wrote:

Hi @thewtex,

Good point. Hopefully, it shouldn't be needed. I am just anticipating some possible specific tweak before backporting changes upstream. patched-2 could be seen as a staging area before the change are integrated into the official repo.

Next week, I will be in Boston for the CTK hackfest and i will be working on that.

Jc


Reply to this email directly or view it on GitHub:
#2 (comment)

@jcfr
Copy link
Member

jcfr commented Jul 10, 2012

@jcfr jcfr closed this Jul 10, 2012
@thewtex
Copy link

thewtex commented Jul 10, 2012

Excellence.

On Tue, Jul 10, 2012 at 9:15 PM, Jean-Christophe Fillion-Robin
reply@reply.github.com
wrote:

See https://github.com/commontk/PythonQt#patched-2


Reply to this email directly or view it on GitHub:
#2 (comment)

wesen added a commit to wesen/PythonQt that referenced this pull request May 27, 2014
jcfr pushed a commit that referenced this pull request Aug 2, 2022
hjmjohnson pushed a commit to hjmjohnson/PythonQt that referenced this pull request Jun 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants