Hebrew translation of pol.is

[daniel-skywalker]

Hello,

I am looking to implement pol.is in a public participation process in Israel (climate conferences).

I see here that there is no translation to Hebrew, or to any RTL language.

Who could assist me in creating this file and committing it appropriately? I will do all the translation just need a bit of help with the technical part.

Also - if there is an idea how to easily make the interface RTL that would be an amazing plus (though not a must).

Thank you!
Daniel

@metasoarous

[patcon]

EDIT: the translation app at http://polis-translations.herokuapp.com/ was an experiment that is no longer used, and the link is intentionally dead.

---

Heyo Daniel! Thanks so so much for being willing to contribute :)

Here are the general steps for adding new translations:

1. minimum: adding translation for "participation" interface (what people use to vote/comment)
   1. visit client-participation/js/strings/
   2. copy contents of en_us.js
   3. create he.js in the same directory by clicking "Add file" button on the directory page, or this shortcut link
   4. copy contents, and edit the values (on the right), but leave all the keys as-is (on the left). even a bad translation is better than none.
   5. When done, click "commit" at bottom.
2. stretch goal: do the same for "admin" interface at client-admin/src/strings/
   • note that this is simply banking non-english translations for later (while a language-speaker is willing to offer it), but currently translations aren't active for the admin interface:

     polis/client-admin/src/strings/strings.js

     Lines 7 to 8 in f526a14

     	// TODO port language choosing code
     	s = en_us

3. stretch goal: add the code to load the new languages in these files, copying same format other languages use:
   • client-participation/js/strings.js
   • client-admin/src/strings/strings.js
   • i'm happy to do this after if this doesn't seem doable :)
4. ultra stretch goal: modify the existing "end-to-end" test that automatically confirms translations in this language are working on each future update to the codebase. add a line here for hebrew, copying existing block of code for other languages: https://github.com/pol-is/polis/blob/dev/e2e/cypress/integration/polis/client-participation/i18n.spec.js
   • i'm happy to do this after if this doesn't seem doable :)

Lemme know if you have any questions! And again, thanks so much!

Ps, adding RTL support isn't totally clear how to do, and will require some research and work, so I can't offer much guidance. You are certainly welcome to take a run at it, and it would be supremely appreciated! #513

EDIT: not yet translatable: email templates, ...

[daniel-skywalker]

Hey Patrick! I did 1,3,4. Hopefully correctly. I made the changes then created a pull request for each.
True: I was a programming teacher and among other things taught GIT
Also True: To this day I have no idea what a pull request is
So hopefully I did it right and might be I'll be able to create a Hebrew conversation soon?
Let me know how I can proceed.

Thanks for the details instructions!!

Ps RTL is nice to have. Let's see how it looks without it first.

[patcon]

Great! Yay! Merged your contributions into one PR: #927

(Please feel free to close the others when you get a sec. [EDIT: realized I could close them. Done!] Though I pulled your work into my own pull request, I "cherry-picked" (in Git terminology), and so it will still show you as a project contributor on GitHub after this gets merged :)

[daniel-skywalker]

Thanks Patrick!
Will y'all let me know when it's merged? I'd really like to try playing around with the Hebrew version once it's approved!!

[patcon]

sorry, it's all happening in #927 and in @colinmegill and @metasoarous' hands

[daniel-skywalker]

Thanks Patrick! Will let you know how far I get :)

…

On Wed, Jan 13, 2021 at 7:03 PM Patrick Connolly ***@***.***> wrote: Heyo Daniel! Thanks so so much for being willing to contribute :) Here are the general steps for adding new translations: 1. minimum: adding translation for "participation" interface (what people use to vote/comment) 1. visit client-participation/js/strings/ <https://github.com/pol-is/polis/tree/dev/client-participation/js/strings> 2. copy contents of en_us.js 3. create he.js in the same directory by clicking "Add file" button on the directory page, or this shortcut link <https://github.com/pol-is/polis/new/dev/client-participation/js/strings/?filename=strings/he.js> 4. copy contents, and edit the values (on the right), but leave all the keys as-is (on the left). even a bad translation is better than none. 5. When done, click "commit" at bottom. 2. stretch goal: do the same for "admin" interface at client-admin/src/strings/ <https://github.com/pol-is/polis/tree/dev/client-admin/src/strings> 3. stretch goal: add the code to load the new languages in these files, copying same format other languages use: - client-participation/js/strings.js <https://github.com/pol-is/polis/blob/dev/client-participation/js/strings.js> - client-admin/src/strings/strings.js <https://github.com/pol-is/polis/blob/dev/client-admin/src/strings/strings.js> - i'm happy to do this after if this doesn't seem doable :) 4. ultra stretch goal: modify the existing "end-to-end" test that automatically confirms translations in this language are working on each future update to the codebase. add a line here for hebrew, copying existing block of code for other languages: https://github.com/pol-is/polis/blob/dev/e2e/cypress/integration/polis/client-participation/i18n.spec.js - i'm happy to do this after if this doesn't seem doable :) Lemme know if you have any questions! And again, thanks so much! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#761 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANAMXFZUWISPSI7L4AHP4ELSZXG4XANCNFSM4WAZEJ4Q> .