Feature/sirodoht crk/e2e version 11

[crkrenn]

This is a pull request that merges @sirodoht's fixes and improvements (https://github.com/sirodoht/suburb/tree/master/e2e) to the e2e testing into edge.

Most notably, the tests work with cypress version 11 (and probably 12).

Not all of the tests passed, but I think it is still worth merging in, given that none of the current e2e tests run. (https://github.com/compdemocracy/polis/actions/runs/3668258553/jobs/6201264217 took 45 minutes, and no tests ran.)

I'm afraid that the way I am submitting this pull request, @sirodoht will not get appropriate credit in the github stats. I'm happy to wait a short amount of time to resolve this issue.

I did try to break up the changes into manageable bits. The only significant coding changes are gathered together in the 8511a51 commit.

Very respectfully,

-Chris

    Spec                                              Tests  Passing  Failing  Pending  Skipped  
  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ ✖  emails.cy.js                             00:01        2        -        1        -        1 │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✖  configure.cy.js                          00:11        2        1        1        -        - │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  convo_access.cy.js                       00:07        6        6        -        -        - │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  create_user.cy.js                        00:08        2        2        -        -        - │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  home.cy.js                               00:02        2        2        -        -        - │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  public_pages.cy.js                       00:01        2        2        -        -        - │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  routes.cy.js                             00:06        5        5        -        -        - │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  share.cy.js                              00:09        2        2        -        -        - │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  signin.cy.js                             00:05        1        1        -        -        - │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✖  comment-translation.secrets.cy.js        00:07        2        1        1        -        - │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  embeds.cy.js                              83ms       10        -        -       10        - │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  i18n.cy.js                               00:06       16       16        -        -        - │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  integration.cy.js                         84ms        7        -        -        7        - │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✖  kitchensink.cy.js                        00:06        1        -        1        -        - │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✖  social-login.cy.js                       00:30        4        -        1        -        3 │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘
    ✖  5 of 15 failed (33%)                     01:45       64       38        5       17        4  

[sirodoht]

Hey @crkrenn! Glad you've found my changes useful! No problem at all for the credit/commit author; the code is the point, not who writes it!

[crkrenn]

Hey @crkrenn! Glad you've found my changes useful! No problem at all for the credit/commit author; the code is the point, not who writes it!

@sirodoht,

Yes, I'm very grateful for your code!

I did try one more time to give you credit (with git checkout --patch branch2 file.py), but no luck.

The current pull request maintains history, and I will get "blamed" for cypress edits, so I'd recommend to merge this branch once the rest of the team is happy.

[metasoarous]

Thanks so much for being flexible with author attribution @sirodoht! And doubly so for doing the legwork to get e2e working again. Looking forward to this improving our velocity.

Thanks also to you @crkrenn for pulling these changes in.

[metasoarous]

PS I was able to add author attribution in the squash merge commit message so you get credit after all @sirodoht :-) Thanks again!