Reduced bundlesize by requiring only victory-core for VictoryAnimation #1618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ballPointPenguin
approved these changes
Feb 9, 2023
|
Did a manual check of alternate visualization here, which should be the only thing using react/victory, and everything looks to be working just fine. |
ballPointPenguin
pushed a commit
that referenced
this pull request
Feb 26, 2023
* edge: (22 commits) Configuration unification (#1617) housekeeping (#1622) Remove intercom (#1547) Reduced bundlesize by requiring only victory-core for VictoryAnimation component. (#1618) A variety of improvements all around (#1608) Update client-participation dependencies, and get off gulp -> webpack (#1607) Feature/crkrenn/fixed participants extended sql table (#1586) Switch server to debian (#1600) More slack removal (#1599) Update server node & misc dep versions (#1595) switch from npm ci to npm install in client dockerfiles (#1594) deleted docker_cloud_notes (#1597) Remove slack (#1585) specify bullseye debian base for math dockerfile (#1590) Feature/crkrenn/improved makefile (#1577) Adding direction to the client- participation (#1561) update winston package (#1584) add scaling roadmap doc (#1582) Feature/sirodoht crk/e2e version 11 (#1576) German language editing (#1552) ...
ballPointPenguin
pushed a commit
that referenced
this pull request
Mar 4, 2023
* edge: (22 commits) Configuration unification (#1617) housekeeping (#1622) Remove intercom (#1547) Reduced bundlesize by requiring only victory-core for VictoryAnimation component. (#1618) A variety of improvements all around (#1608) Update client-participation dependencies, and get off gulp -> webpack (#1607) Feature/crkrenn/fixed participants extended sql table (#1586) Switch server to debian (#1600) More slack removal (#1599) Update server node & misc dep versions (#1595) switch from npm ci to npm install in client dockerfiles (#1594) deleted docker_cloud_notes (#1597) Remove slack (#1585) specify bullseye debian base for math dockerfile (#1590) Feature/crkrenn/improved makefile (#1577) Adding direction to the client- participation (#1561) update winston package (#1584) add scaling roadmap doc (#1582) Feature/sirodoht crk/e2e version 11 (#1576) German language editing (#1552) ...
ballPointPenguin
pushed a commit
that referenced
this pull request
Mar 5, 2023
* edge: (22 commits) Configuration unification (#1617) housekeeping (#1622) Remove intercom (#1547) Reduced bundlesize by requiring only victory-core for VictoryAnimation component. (#1618) A variety of improvements all around (#1608) Update client-participation dependencies, and get off gulp -> webpack (#1607) Feature/crkrenn/fixed participants extended sql table (#1586) Switch server to debian (#1600) More slack removal (#1599) Update server node & misc dep versions (#1595) switch from npm ci to npm install in client dockerfiles (#1594) deleted docker_cloud_notes (#1597) Remove slack (#1585) specify bullseye debian base for math dockerfile (#1590) Feature/crkrenn/improved makefile (#1577) Adding direction to the client- participation (#1561) update winston package (#1584) add scaling roadmap doc (#1582) Feature/sirodoht crk/e2e version 11 (#1576) German language editing (#1552) ...
ballPointPenguin
pushed a commit
that referenced
this pull request
Mar 6, 2023
* edge: (22 commits) Configuration unification (#1617) housekeeping (#1622) Remove intercom (#1547) Reduced bundlesize by requiring only victory-core for VictoryAnimation component. (#1618) A variety of improvements all around (#1608) Update client-participation dependencies, and get off gulp -> webpack (#1607) Feature/crkrenn/fixed participants extended sql table (#1586) Switch server to debian (#1600) More slack removal (#1599) Update server node & misc dep versions (#1595) switch from npm ci to npm install in client dockerfiles (#1594) deleted docker_cloud_notes (#1597) Remove slack (#1585) specify bullseye debian base for math dockerfile (#1590) Feature/crkrenn/improved makefile (#1577) Adding direction to the client- participation (#1561) update winston package (#1584) add scaling roadmap doc (#1582) Feature/sirodoht crk/e2e version 11 (#1576) German language editing (#1552) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulling this change in separately from #1225.
I don't think we want to switch lodash import style. We recently switched out
underscorefor lodash across other parts of the participation client, so I'm not sure that this would have as significant an impact on bundlesize any longer, and we should already be smaller for leaving out underscore (also, the proposed changes only affected bundlesize by 6% in the original PR, which is pretty minimal to begin with).However, if as claimed switching from
victorytovictory-coreis a 36% increase, that's definitely worth while, so pulling that in here.