Add raises-exception as tag for ignoring exceptions #64
Conversation
Next version of notebook will continue to run through cells that raise error if the tag "raises-exception" is included in the metadata tag. This edit allows this feature from notebook to be included in nbval. See jupyter/notebook#2549
|
Having trouble with something that seems to have worked before that hasn't changed -- the presence of two warnings generated on the same cell is raising issues for Python 2.7 and 3.4 (but not later versions) -- did something possibly change in the version of py.test that we are testing against since the last build? |
|
I believe this is an issue with py.test, yes (still working on narrowing it down). At the very least it should be independent of this PR, as master have the same failures. As all the tests are run and pass, feel free to consider this PR as OK. The ZeroDivisionError commit should also be unnecessary, so you can drop that. |
|
Fix for CI error in #65. |
|
I think that the ZeroDivision commit is actually necessary, not for the Py2.7+Py3.4 bug but because the traceback returned in Py2.7 for a ZeroDivisionError is different from that for Py3. In either case, I think that it's good to go together w/#65. |
|
@mscuthbert Yes, I see I got confused about what that commit was changing. Leave it in 👍 |
|
Closing and reopening to rerun the tests with updated master. |
3 participants
Following on the ability to use tags to detect known exception raising, jupyter/notebook#2516 implemented in jupyter/notebook#2549 allows Jupyter notebook to use a tag to indicate that code execution should not halt because it encountered an exception. However the tag that that team wanted "raises-exception" is unprefixed -- this commit allows nbval (which is amazing btw!) to use the unprefixed tag in addition to the nbval-raises-exception version