-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[package] util-linux-libuuid uses wrong cmake target #18554
Comments
…uuid::libuuid * This is in line with what conan recipes seem to expect, which will minimise the number of patches required. LibUUID was chosen as the target name given this is what's used internally within cmake, but this isn't a public interface and so there is no common usage to take guidance from. Closes conan-io#18554
I've made a comment on the PR: #18559 I think there is an argument that Given that there are only 10 recipes that need to be updated to use |
Good point. That's a good way to identify commonality. In contrast, looks like |
This may indeed be the case, however, I can see that in those instances, project-private find modules are used. The only find modules that we consider authoritative are the CMake built-in. Each may have different conventions. For specific cases where a project uses a custom name, we have the ability to tweak the target name in the |
…ID to libuuid::libuuid * [util-linux-libuuid] Change CMake target from LibUUID::LibUUID to libuuid::libuuid * This is in line with what conan recipes seem to expect, which will minimise the number of patches required. LibUUID was chosen as the target name given this is what's used internally within cmake, but this isn't a public interface and so there is no common usage to take guidance from. Closes #18554 * add alias for LibUUID::LibUUID --------- Co-authored-by: Luis Caro Campos <3535649+jcar87@users.noreply.github.com>
…D::LibUUID to libuuid::libuuid * [util-linux-libuuid] Change CMake target from LibUUID::LibUUID to libuuid::libuuid * This is in line with what conan recipes seem to expect, which will minimise the number of patches required. LibUUID was chosen as the target name given this is what's used internally within cmake, but this isn't a public interface and so there is no common usage to take guidance from. Closes conan-io#18554 * add alias for LibUUID::LibUUID --------- Co-authored-by: Luis Caro Campos <3535649+jcar87@users.noreply.github.com>
Description
In the following lines, the
util-linux-libuuid
recipe sets the cmake target to beLibUUID::LibUUID
with a filename ofLibUUID-config.cmake
:conan-center-index/recipes/util-linux-libuuid/all/conanfile.py
Lines 112 to 113 in 61c4f78
This was based on the internal practice that Kitware has for their internal libuuid cmake module, however this is not public and a number of packages (czmq, cppcommon) seem to assume a
libuuid::libuuid
target. These change should be reverted such that these packages can utilise util-linux-libuuid without a requirement to be patched.Package and Environment Details
N/A
Conan profile
N/A
Steps to reproduce
N/A
Logs
Click to expand log
The text was updated successfully, but these errors were encountered: