[package] catch2/2.9.2: Expected CMake scripts to be included in the package

[pleroux0]

Package and Environment Details (include every applicable attribute)

• Package Name/Version: catch2/2.9.2

I expected to have access to cmake scripts that are installed with Catch2.

The helper scripts are set to be installed.

conan-center-index/recipes/catch2/2.x.x/conanfile.py

Line 33 in 6a7ff72

cmake.definitions["CATCH_INSTALL_HELPERS"] = "ON"

Then they are deleted during packaging.

conan-center-index/recipes/catch2/2.x.x/conanfile.py

Line 51 in 6a7ff72

tools.rmdir(os.path.join(self.package_folder, "lib", "cmake"))

Currently, I am using the older bincrafters package (catch2/2.5.0@bincrafters/stable) which still includes the CMake scripts. I would need to maintain my own conan package to use the newer version of Catch2.

[danimtb]

See discussion here #209

[Morwenn]

Catch2 provides more than just install scripts though: some of the provided CMake scripts such as CatchAddTests.cmake allow to discover Catch tests in the source and register them as CTest tests. It's notably not the Config.cmake files and yet they seem to be removed to from the package.

Those scripts should be kept since they're not meant for dependency discovery.

[danimtb]

In that case, it is totally fine to have them packaged. Thanks for the info @Morwenn

[pleroux0]

Thanks for the response

@Morwenn That is exactly my use case. I use catch_discover_tests.

@danimtb I'll keep updated with conan-io/conan#5798 and #209 for now. For now, I'll keep using the old package. Do you want to close this issue or keep it open to specifically track the catch2 package?

[Morwenn]

If I understand correctly this issue is independent of the ones you linked to: they try to solve the problems with packages that provide more than the basic dependency mechanisms in Find*.cmake and *Config.cmake files. In the test of Catch2 the relevant files are separate from the dependency-finding ones, so we should update the Catch2 recipe to not get rid of them.

[pleroux0]

The CMake scripts require the config file to be loaded so that they are in the path. The first bullet point of conan-io/conan#5798 (comment) should fix this.

Edit: Fixed typo

[pleroux0]

This issue is not fixed as CatchAddTests.cmake is still missing from the package, which is required by catch_discover_tests.

[pleroux0]

@danimtb Can you please re-open this issue?

[uilianries]

@pleroux0 I gonna submit a new PR with a fix. Thanks for reporting

[Morwenn]

Can this issue be closed?

[danimtb]

Closed by #292. Thanks @Morwenn!